Page MenuHomeSoftware Heritage
Differential D399

deposit/loader: Add missing origin_url transmission step
ClosedPublic
Actions

Authored by ardumont on Jul 23 2018, 12:20 PM.

Details

Reviewers
moranegg
Commits
rDDEP2c4c4840ec38: deposit/loader: Add missing origin_url transmission step
Summary

We need to transmit the origin url needed for the contextual
persistent id computation.

This diff adds the missing step from D396 (merged a tad too fast).

Test Plan

Tests ok

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 23 2018, 12:20 PM
Harbormaster completed remote builds in B1362: Diff 1243.Jul 23 2018, 12:20 PM
ardumont updated this revision to Diff 1244.Jul 23 2018, 1:27 PM

Update the loader's test which clarifies the url source use

Harbormaster completed remote builds in B1363: Diff 1244.Jul 23 2018, 1:27 PM
moranegg accepted this revision.Jul 23 2018, 1:37 PM
This revision is now accepted and ready to land.Jul 23 2018, 1:37 PM
Closed by commit rDDEP2c4c4840ec38: deposit/loader: Add missing origin_url transmission step (authored by ardumont). · Explain WhyJul 23 2018, 1:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
deposit/
client/
5 lines
loader/
11 lines
tests/
loader/
4 lines
28 lines

Diff 1245

View Options

swh/deposit/client/__init__.py

Loading...
View Options

swh/deposit/loader/loader.py

Loading...
View Options

swh/deposit/tests/loader/common.py

Loading...
View Options

swh/deposit/tests/loader/test_loader.py

Loading...
About · Developer information · Legal