Page MenuHomeSoftware Heritage
Differential D393

make-package: Allow to specify the source to build the package for
ClosedPublic
Actions

Authored by ardumont on Jul 18 2018, 1:41 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDENV7a15a19dc45a: make-package: Allow to specify the source to build the package for
Summary

It sometimes happen that the build is broken on unstable due to a
random amount of upstream dependencies failing to build. Thus making
our package build impossible to run completely (stable is our current
infra target).

This allows for avoiding properly the issue by being able to specify the
target to build the package for. And this, without having to locally amend
the script.

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 18 2018, 1:41 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 18 2018, 1:41 PM
Harbormaster completed remote builds in B1350: Diff 1226.Jul 18 2018, 1:41 PM
ardumont edited the summary of this revision. (Show Details)Jul 18 2018, 1:45 PM
ardumont added inline comments.
bin/make-package
16

i missed the tab there, is it normal the lines before are tabbed?

olasd accepted this revision.Jul 18 2018, 1:59 PM
olasd added a subscriber: zack.

I see a bunch of things to improve but I don't think it's reasonable to implement them in shell; this is better than the status quo, I guess :)

bin/make-package
16

I think one of our editor's shell configuration mixes tabs and spaces. I've noticed that before (maybe it was @zack ?)

This revision is now accepted and ready to land.Jul 18 2018, 1:59 PM
ardumont added inline comments.Jul 18 2018, 2:02 PM
bin/make-package
16

I'll fix it since i'm on it.
Thanks for the review.

olasd added a comment.Jul 18 2018, 2:02 PM

(related: T1141)

ardumont updated this revision to Diff 1227.Jul 18 2018, 2:03 PM

Amend with fix of mix tab/spaces

Harbormaster completed remote builds in B1351: Diff 1227.Jul 18 2018, 2:03 PM
ardumont marked 2 inline comments as done.Jul 18 2018, 2:03 PM
Closed by commit rDENV7a15a19dc45a: make-package: Allow to specify the source to build the package for (authored by ardumont). · Explain WhyJul 18 2018, 2:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
68 lines

Diff 1228

View Options

bin/make-package

Loading...
About · Developer information · Legal