Page MenuHomeSoftware Heritage
Differential D3921

cli: speedup the `swh` cli command startup time
ClosedPublic
Actions

Authored by douardda on Sep 10 2020, 4:25 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2575: Investigate if/how we could improve `swh` cli command startup time
Commits
rDSTOfd6d72f98ee8: cli: speedup the `swh` cli command startup time
Summary

by moving import statements in functions, as well as preventing
the loading of swh.storage.interface in swh.storage unless needed
for type checking.

Related to T2575.

Diff Detail

Unit TestsFailed
View All

TimeTest
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_cli::test_replay
@pytest.fixture def swh_storage(): """An swh-storage object that gets injected into the CLI functions."""
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_content
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin_visit
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_revision
View Full Test Results (1 Failed · 747 Passed · 23 Skipped)

Event Timeline

douardda created this revision.Sep 10 2020, 4:25 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 10 2020, 4:25 PM
swh-public-ci added a comment.Sep 10 2020, 4:30 PM

Build has FAILED

Patch application report for D3921 (id=13781)

Rebasing onto d24a1e7732...

First, rewinding head to replay your work on top of it...
Applying: cli: speedup the `swh` cli command startup time
Changes applied before test
commit 11fb17cb7ec5f5d801fd73cb68376d72b1fbb631
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 15:15:33 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions, as well as preventing
    the loading of swh.storage.interface in swh.storage unless needed
    for type checking.
    
    Related to T2575.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/915/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/915/console

Harbormaster failed remote builds in B15008: Diff 13781!Sep 10 2020, 4:30 PM
vlorentz added a subscriber: vlorentz.Sep 10 2020, 4:45 PM
vlorentz added inline comments.
swh/storage/__init__.py
26

string

73

string

douardda updated this revision to Diff 13811.Sep 10 2020, 5:38 PM

use string annotations

swh-public-ci added a comment.Sep 10 2020, 5:42 PM

Build has FAILED

Patch application report for D3921 (id=13811)

Rebasing onto d24a1e7732...

First, rewinding head to replay your work on top of it...
Applying: cli: speedup the `swh` cli command startup time
Changes applied before test
commit 2822031b8db2d9bd2510b5df7b63af0bde551122
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 15:15:33 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions, as well as preventing
    the loading of swh.storage.interface in swh.storage unless needed
    for type checking.
    
    Related to T2575.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/916/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/916/console

Harbormaster failed remote builds in B15036: Diff 13811!Sep 10 2020, 5:42 PM
douardda updated this revision to Diff 13814.Sep 10 2020, 6:41 PM

pfff

swh-public-ci added a comment.Sep 10 2020, 6:46 PM

Build has FAILED

Patch application report for D3921 (id=13814)

Rebasing onto d24a1e7732...

First, rewinding head to replay your work on top of it...
Applying: cli: speedup the `swh` cli command startup time
Changes applied before test
commit ab81a73d2ef97f38a730aa0a99b1de860d7c42d2
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 15:15:33 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions, as well as preventing
    the loading of swh.storage.interface in swh.storage unless needed
    for type checking.
    
    Related to T2575.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/917/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/917/console

vlorentz accepted this revision.Sep 10 2020, 6:46 PM
This revision is now accepted and ready to land.Sep 10 2020, 6:46 PM
Harbormaster failed remote builds in B15039: Diff 13814!Sep 10 2020, 6:46 PM
douardda updated this revision to Diff 13829.Sep 11 2020, 11:16 AM

rebase + fix test_cli

swh-public-ci added a comment.Sep 11 2020, 11:21 AM

Build is green

Patch application report for D3921 (id=13829)

Rebasing onto d24a1e7732...

Current branch diff-target is up to date.
Changes applied before test
commit fd6d72f98ee8c79feaced17e44fe1076f71d0595
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 15:15:33 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions, as well as preventing
    the loading of swh.storage.interface in swh.storage unless needed
    for type checking.
    
    Related to T2575.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/918/ for more details.

Harbormaster completed remote builds in B15054: Diff 13829.Sep 11 2020, 11:21 AM
Closed by commit rDSTOfd6d72f98ee8: cli: speedup the `swh` cli command startup time (authored by douardda). · Explain WhySep 11 2020, 11:45 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDSTOfd6d72f98ee8: cli: speedup the `swh` cli command startup time.

Revision Contents
Changeset List

PathSize
swh/
storage/
9 lines
17 lines

Diff 13811

View Options

swh/storage/__init__.py

Loading...
View Options

swh/storage/cli.py

Loading...
About · Developer information · Legal