Use absolute import
ClosedPublic
Actions

Authored by douardda on Sep 10 2020, 4:19 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2575: Investigate if/how we could improve `swh` cli command startup time

Commits

rDOBJSf793e63dca74: cli: speedup the `swh` cli command startup time
rDOBJSf6e9b0149a35: Use absolute import

Summary

cli: speedup the swh cli command startup time

by moving import statements in functions and stop importing
swh.objstorage.factory.* in swh.objstorage.

Warning: this later breaks a few dependencies that had not updated
the way they import get_objstorage.

Related to T2575.

Diff Detail

Repository

rDOBJS Object storage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 10 2020, 4:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 10 2020, 4:19 PM

Build is green

Patch application report for D3917 (id=13776)

Rebasing onto d36bf1631f...

Current branch diff-target is up to date.

Changes applied before test

commit f793e63dca7437f35ae9cff40112262d28c6dd82
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 09:38:41 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions and stop importing
    swh.objstorage.factory.* in swh.objstorage.
    
    Warning: this later breaks a few dependencies that had not updated
    the way they import get_objstorage.
    
    Related to T2575.

commit f6e9b0149a3513148970bafd985b83534496d3cb
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Sep 9 18:57:52 2020 +0200

    Use absolute import

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/14/ for more details.

Harbormaster completed remote builds in B15003: Diff 13776.Sep 10 2020, 4:21 PM

vlorentz accepted this revision.Sep 10 2020, 4:44 PM

This revision is now accepted and ready to land.Sep 10 2020, 4:44 PM

Closed by commit rDOBJSf6e9b0149a35: Use absolute import (authored by douardda). · Explain WhySep 10 2020, 5:13 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDOBJSf6e9b0149a35: Use absolute import.

douardda added a commit: rDOBJSf793e63dca74: cli: speedup the `swh` cli command startup time.