Differential D3910

cli: speedup the `swh` cli command startup time
ClosedPublic
Actions

Authored by douardda on Sep 10 2020, 4:11 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2575: Investigate if/how we could improve `swh` cli command startup time

Commits

rDGRPH4a643fcce445: cli: speedup the `swh` cli command startup time

Summary

by moving import statements in functions. Also move the definition
of StepOption in swh.graph.cli since it's purely a click dedicated
class.

Related to T2575.

Diff Detail

Repository

rDGRPH Compressed graph representation

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 14996
Build 23107: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23106: arc lint + arc unit

Event Timeline

douardda created this revision.Sep 10 2020, 4:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 10 2020, 4:11 PM

douardda added a child revision: D3911: refactor and simplify test_cli as a pytest function.Sep 10 2020, 4:11 PM

Build is green

Patch application report for D3910 (id=13769)

Rebasing onto 8c937da207...

Current branch diff-target is up to date.

Changes applied before test

commit 4a643fcce445cc5efc3d1442092578e962363498
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 10:56:11 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions. Also move the definition
    of StepOption in swh.graph.cli since it's purely a click dedicated
    class.
    
    Related to T2575.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/25/ for more details.

Harbormaster completed remote builds in B14996: Diff 13769.Sep 10 2020, 4:12 PM

vlorentz accepted this revision.Sep 10 2020, 4:42 PM

This revision is now accepted and ready to land.Sep 10 2020, 4:42 PM

Closed by commit rDGRPH4a643fcce445: cli: speedup the `swh` cli command startup time (authored by douardda). · Explain WhySep 10 2020, 5:17 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDGRPH4a643fcce445: cli: speedup the `swh` cli command startup time.