Differential D3909

cli: speedup the `swh` cli command startup time
ClosedPublic
Actions

Authored by douardda on Sep 10 2020, 4:09 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2575: Investigate if/how we could improve `swh` cli command startup time

Commits

rDDEPde0ab7f6f21f: cli: speedup the `swh` cli command startup time

Summary

by moving import statements in functions.

Related to T2575.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 10 2020, 4:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 10 2020, 4:09 PM

Build has FAILED

Patch application report for D3909 (id=13768)

Rebasing onto 7c5c84b595...

Current branch diff-target is up to date.

Changes applied before test

commit f8d9a8404572abed76bd8a1dcb7cb11a6c455d9f
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Sep 9 18:22:50 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions.
    
    Related to T2575.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/62/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/62/console

Harbormaster failed remote builds in B14995: Diff 13768!Sep 10 2020, 4:11 PM

vlorentz accepted this revision.Sep 10 2020, 4:41 PM

This revision is now accepted and ready to land.Sep 10 2020, 4:41 PM

fix test_cli

broken by (moved) mocked objects.

Build is green

Patch application report for D3909 (id=13789)

Rebasing onto 7c5c84b595...

Current branch diff-target is up to date.

Changes applied before test

commit de0ab7f6f21fb26fb0e59c16eeb5117d22ada2fd
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Sep 9 18:22:50 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions.
    
    Related to T2575.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/63/ for more details.

Harbormaster completed remote builds in B15015: Diff 13789.Sep 10 2020, 5:12 PM

Closed by commit rDDEPde0ab7f6f21f: cli: speedup the `swh` cli command startup time (authored by douardda). · Explain WhySep 10 2020, 5:17 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDDEPde0ab7f6f21f: cli: speedup the `swh` cli command startup time.