Page MenuHomeSoftware Heritage

Add edge labelling prototype
ClosedPublic

Authored by seirl on Thu, Sep 10, 3:28 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Summary

This diff adds a way to handle labels for edges. It's not integrated
to the rest of the stack yet, it's just a prototype that we use for scientific
collaborations.

Test Plan

No automated tests, but it has been tested on a small dataset and is
able to reproduce the original labelled graph from the compressed version.

Diff Detail

Repository
rDGRPH Graph service
Branch
edge_labels
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15103
Build 23286: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23285: arc lint + arc unit

Event Timeline

seirl created this revision.Thu, Sep 10, 3:28 PM

Build is green

Patch application report for D3906 (id=13765)

Rebasing onto 8c937da207...

Current branch diff-target is up to date.
Changes applied before test
commit 32638f2012aba082c775efafd9a1c5c0f1834af6
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Sep 10 09:44:02 2020 +0200

    java: labelling: allow multiple labels per edge

commit aa4912fb9559f618070071982d1055c431a390db
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Sep 10 09:43:36 2020 +0200

    java: cleanup MPHTranslate

commit 75db62881477a63a055a0ff54175307a0bad37b1
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Sep 4 14:28:41 2020 +0200

    java: add label utils (MPH translator and graph readers)

commit 0e39eb7e9cfa7257274961aff55e39c49e056e36
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Tue Aug 11 21:39:18 2020 +0200

    java: LabelMapBuilder: use MPH + .order instead of the binary map

commit 96e91515184a6b726387f9b584f3a6b141d15e1c
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Tue Aug 11 21:12:15 2020 +0200

    java: add LabelMapBuilder (first iteration)

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/24/ for more details.

douardda accepted this revision.Mon, Sep 14, 1:14 PM
douardda added a subscriber: douardda.

LGTM, as far as I can tell (but I cannot tell that much TBH)

This revision is now accepted and ready to land.Mon, Sep 14, 1:14 PM

Build is green

Patch application report for D3906 (id=13878)

Rebasing onto c7df913df2...

Current branch diff-target is up to date.
Changes applied before test
commit eaf0323a1c0194775235bf1f87308fccbf005be2
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Sep 10 09:44:02 2020 +0200

    java: labelling: allow multiple labels per edge

commit 4e2a94b3f3b29cde8b1e51d75b64bcdec8db0782
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Sep 10 09:43:36 2020 +0200

    java: cleanup MPHTranslate

commit a315f1b900226f7ea0dd64f6bce4c94703b5769a
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Sep 4 14:28:41 2020 +0200

    java: add label utils (MPH translator and graph readers)

commit 555734272f5cfb1c78d962ba37b62eb7f8dd635e
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Tue Aug 11 21:39:18 2020 +0200

    java: LabelMapBuilder: use MPH + .order instead of the binary map

commit ca3cb2b5e99bcf54aba77488afa855575b0e9d55
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Tue Aug 11 21:12:15 2020 +0200

    java: add LabelMapBuilder (first iteration)

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/27/ for more details.

seirl closed this revision.Mon, Sep 14, 2:43 PM