Page MenuHomeSoftware Heritage

gitea.tasks: Fix parameter name from 'sort' to 'order'
ClosedPublic

Authored by ardumont on Wed, Sep 9, 12:12 PM.

Details

Summary

This fixes [1]

[1] https://sentry.softwareheritage.org/share/issue/b0119b56f24347bcb58ac28c68685c62/

Note:
It passed unseen because tasks tests are mocked, so no instantiation from the associated Lister class is happening...

Related to T2577

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Wed, Sep 9, 12:12 PM

Build is green

Patch application report for D3897 (id=13739)

Rebasing onto 7d44bc2e75...

Current branch diff-target is up to date.
Changes applied before test
commit 66a61f3dd23429de894b775cc6ab83f48c1e6b29
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 9 12:10:23 2020 +0200

    gitea.tasks: Fix parameter name from 'sort' to 'order'
    
    This fixes [1]
    
    [1] https://sentry.softwareheritage.org/share/issue/b0119b56f24347bcb58ac28c68685c62/

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/39/ for more details.

ardumont edited the summary of this revision. (Show Details)Wed, Sep 9, 12:15 PM
ardumont added a project: Lister.
olasd accepted this revision.Wed, Sep 9, 3:09 PM
This revision is now accepted and ready to land.Wed, Sep 9, 3:09 PM
This revision was automatically updated to reflect the committed changes.