Page MenuHomeSoftware Heritage
Differential D3890

spec-meta-deposit: fix XML indent
ClosedPublic
Actions

Authored by vlorentz on Sep 8 2020, 3:14 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T2312: Review metadata deposit specs for metadata-only deposit
Commits
rDDEP88381e36c75d: spec-meta-deposit: fix XML indent

Diff Detail

Repository
rDDEP Push deposit
Branch
spec-meta-deposit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14954
Build 23038: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23037: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 8 2020, 3:14 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 8 2020, 3:14 PM
swh-public-ci added a comment.Sep 8 2020, 3:16 PM

Build is green

Patch application report for D3890 (id=13726)

Rebasing onto 7c5c84b595...

First, rewinding head to replay your work on top of it...
Applying: spec-meta-deposit: fix XML indent
Changes applied before test
commit 4e3b789d8a472ca683ea1817a26ac4299f9551c3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 8 15:13:56 2020 +0200

    spec-meta-deposit: fix XML indent

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/55/ for more details.

Harbormaster completed remote builds in B14954: Diff 13726.Sep 8 2020, 3:16 PM
anlambert accepted this revision.Sep 8 2020, 3:19 PM
anlambert added a subscriber: anlambert.

Nitpick: the indent level is not consistent (sometimes 2 spaces, sometimes 4).

This revision is now accepted and ready to land.Sep 8 2020, 3:19 PM
vlorentz added a comment.Sep 8 2020, 3:24 PM

Indeed. But this diff is at the bottom of the stack, so I'll change it later

vlorentz added a task: T2312: Review metadata deposit specs for metadata-only deposit.Sep 8 2020, 9:03 PM
vlorentz updated this revision to Diff 13821.Sep 11 2020, 10:30 AM

rebase + apply comment

This revision was landed with ongoing or failed builds.Sep 11 2020, 10:35 AM
Closed by commit rDDEP88381e36c75d: spec-meta-deposit: fix XML indent (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEP88381e36c75d: spec-meta-deposit: fix XML indent.
swh-public-ci added a comment.Sep 11 2020, 10:41 AM

Build is green

Patch application report for D3890 (id=13821)

Rebasing onto ec8dcc1ead...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-68-D3890.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/68/ for more details.
Harbormaster completed remote builds in B15046: Diff 13821.Sep 11 2020, 10:41 AM
Revision Contents
Changeset List
PathSize
docs/
specs/
60 lines
Diff 13726
View Options
docs/specs/spec-meta-deposit.rst
Loading...
About · Developer information · Legal