Differential D3869

test_loader: Adapt to latest storage revision_get change
ClosedPublic
Actions

Authored by ardumont on Sep 3 2020, 1:20 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDLDHG0e86a987ead9: test_loader: Adapt to latest storage revision_get change

Summary

Related to T645

Test Plan

tox
(failing until release storage > 0.13.3 and loader.core > 0.9.1

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 3 2020, 1:20 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 3 2020, 1:20 PM

ardumont mentioned this in D3863: Refactor revision_get storage API to return Revision objects.Sep 3 2020, 1:20 PM

Build has FAILED

Patch application report for D3869 (id=13661)

Rebasing onto 3baeea1fab...

Current branch diff-target is up to date.

Changes applied before test

commit 0e86a987ead98f72dae9deb3eba7ba588c0849a0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 2 16:03:07 2020 +0200

    test_loader: Adapt to latest storage revision_get change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/41/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/41/console

Harbormaster failed remote builds in B14894: Diff 13661!Sep 3 2020, 1:21 PM

vlorentz accepted this revision.Sep 3 2020, 1:53 PM

This revision is now accepted and ready to land.Sep 3 2020, 1:53 PM

Build is green

Patch application report for D3869 (id=13661)

Rebasing onto 3baeea1fab...

Current branch diff-target is up to date.

Changes applied before test

commit 0e86a987ead98f72dae9deb3eba7ba588c0849a0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 2 16:03:07 2020 +0200

    test_loader: Adapt to latest storage revision_get change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/42/ for more details.

Harbormaster completed remote builds in B14894: Diff 13661.Sep 4 2020, 1:35 PM

Closed by commit rDLDHG0e86a987ead9: test_loader: Adapt to latest storage revision_get change (authored by ardumont). · Explain WhySep 4 2020, 1:57 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDHG0e86a987ead9: test_loader: Adapt to latest storage revision_get change.