Differential D3865

metadata: Adapt to latest storage revision_get change
ClosedPublic
Actions

Authored by ardumont on Sep 2 2020, 4:08 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDCIDX32994d21d715: metadata: Adapt to latest storage revision_get change

Summary

Related to T645

Test Plan

tox
(failing until swh.storage release > 0.13.3)

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 2 2020, 4:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 2 2020, 4:08 PM

ardumont mentioned this in D3863: Refactor revision_get storage API to return Revision objects.Sep 2 2020, 4:08 PM

Build has FAILED

Patch application report for D3865 (id=13653)

Rebasing onto 31675bd0e1...

Current branch diff-target is up to date.

Changes applied before test

commit 32994d21d7158038fa91cb4228c2b81be282cfed
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 2 16:08:41 2020 +0200

    metadata: Adapt to latest storage revision_get change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/47/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/47/console

Harbormaster failed remote builds in B14886: Diff 13653!Sep 2 2020, 4:10 PM

vlorentz accepted this revision.Sep 2 2020, 11:37 PM

This revision is now accepted and ready to land.Sep 2 2020, 11:37 PM

Build is green

Patch application report for D3865 (id=13653)

Rebasing onto 31675bd0e1...

Current branch diff-target is up to date.

Changes applied before test

commit 32994d21d7158038fa91cb4228c2b81be282cfed
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 2 16:08:41 2020 +0200

    metadata: Adapt to latest storage revision_get change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/48/ for more details.

Harbormaster completed remote builds in B14886: Diff 13653.Sep 4 2020, 1:21 PM

Closed by commit rDCIDX32994d21d715: metadata: Adapt to latest storage revision_get change (authored by ardumont). · Explain WhySep 4 2020, 1:25 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDX32994d21d715: metadata: Adapt to latest storage revision_get change.