Page MenuHomeSoftware Heritage

model: Fix "unused 'type: ignore' comment" error with mypy 0.782
ClosedPublic

Authored by anlambert on Aug 25 2020, 3:37 PM.

Details

Summary

Jenkins job for swh-model is currently failing because of that (see https://jenkins.softwareheritage.org/job/DMOD/job/tests/).

Changes in that diff also guarantee that no typing errors will be raised when using mypy<0.782.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3840 (id=13527)

Rebasing onto c85990b97d...

Current branch diff-target is up to date.
Changes applied before test
commit 12fe1f78fcaec673eab025732dcb08005f4459ef
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Aug 25 15:32:37 2020 +0200

    model: Fix "unused 'type: ignore' comment" error with mypy 0.782

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/133/ for more details.

ardumont added a subscriber: ardumont.

Thanks, I started this yesterday but forgot to finish ;)

This revision is now accepted and ready to land.Aug 25 2020, 4:22 PM