Page MenuHomeSoftware Heritage

Rename metadata format 'original-artifact-json' to 'original-artifacts-json'.
ClosedPublic

Authored by vlorentz on Aug 25 2020, 11:52 AM.

Details

Summary

It's a list with one item per file, so it makes sense it should be plural.

No migration needed, as this code wasn't released yet.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

forgot to update tests

Build has FAILED

Patch application report for D3839 (id=13520)

Rebasing onto 1847ffe5e0...

Current branch diff-target is up to date.
Changes applied before test
commit 532e21cda867993961bc68570c197b752bedb783
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 25 11:52:08 2020 +0200

    Rename metadata format 'original-artifact-json' to 'original-artifacts-json'.
    
    It's a list with one item per file, so it makes sense it should be plural.
    
    No migration needed, as this code wasn't released yet.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/289/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/289/console

Build is green

Patch application report for D3839 (id=13521)

Rebasing onto 1847ffe5e0...

Current branch diff-target is up to date.
Changes applied before test
commit ea39a550fa1e6f2093e4a5424c4d9518a04d30e8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 25 11:52:08 2020 +0200

    Rename metadata format 'original-artifact-json' to 'original-artifacts-json'.
    
    It's a list with one item per file, so it makes sense it should be plural.
    
    No migration needed, as this code wasn't released yet.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/290/ for more details.

This revision is now accepted and ready to land.Aug 25 2020, 11:58 AM