Page MenuHomeSoftware Heritage
Differential D3823

assets/vault-ui: Use ejs template to generate vault table row html
ClosedPublic
Actions

Authored by anlambert on Aug 20 2020, 5:01 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPSf1f82b65058a: assets/vault-ui: Use ejs template to generate vault table row html
Summary

Large html templates will use ejs from now on instead of js template strings.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 20 2020, 5:01 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2020, 5:01 PM
swh-public-ci added a comment.Aug 20 2020, 5:08 PM

Build is green

Patch application report for D3823 (id=13454)

Rebasing onto cc53326a84...

Current branch diff-target is up to date.
Changes applied before test
commit f1f82b65058ae8e301e35136ce8e1e52adcd51f0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Aug 20 16:59:59 2020 +0200

    assets/vault-ui: Use ejs template to generate vault table row html

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/338/ for more details.

Harbormaster completed remote builds in B14717: Diff 13454.Aug 20 2020, 5:08 PM
vlorentz accepted this revision.Aug 20 2020, 5:09 PM
This revision is now accepted and ready to land.Aug 20 2020, 5:09 PM
Closed by commit rDWAPPSf1f82b65058a: assets/vault-ui: Use ejs template to generate vault table row html (authored by anlambert). · Explain WhyAug 20 2020, 5:19 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSf1f82b65058a: assets/vault-ui: Use ejs template to generate vault table row html.

Revision Contents
Changeset List

PathSize
cypress/
integration/
2 lines
swh/
web/
assets/
src/
bundles/
vault/
56 lines
58 lines

Diff 13458

View Options

cypress/integration/vault.spec.js

Loading...
View Options

swh/web/assets/src/bundles/vault/vault-table-row.ejs

Loading...
View Options

swh/web/assets/src/bundles/vault/vault-ui.js

Loading...
About · Developer information · Legal