Differential D3806

Fix deserialization of extra_headers.
ClosedPublic
Actions

Authored by vlorentz on Aug 19 2020, 2:53 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDJNL4d3cb983615d: Fix deserialization of extra_headers.

Summary

kafka_to_value didn't recursively convert to tuples, so they were
of type Tuple[List[bytes], ...] instead of Tuple[Tuple[bytes, bytes], ...]

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 19 2020, 2:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 19 2020, 2:53 PM

Build is green

Patch application report for D3806 (id=13409)

Rebasing onto ce6cb80ee1...

Current branch diff-target is up to date.

Changes applied before test

commit 4d3cb983615da70196f74f51b5972dc0a3862784
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 19 14:52:58 2020 +0200

    Fix deserialization of extra_headers.
    
    kafka_to_value didn't recursively convert to tuples, so they were
    of type Tuple[List[bytes], ...] instead of Tuple[Tuple[bytes, bytes], ...]

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/109/ for more details.

Harbormaster completed remote builds in B14673: Diff 13409.Aug 19 2020, 2:54 PM

anlambert accepted this revision.Aug 19 2020, 3:43 PM

This revision is now accepted and ready to land.Aug 19 2020, 3:43 PM

Closed by commit rDJNL4d3cb983615d: Fix deserialization of extra_headers. (authored by vlorentz). · Explain WhyAug 20 2020, 10:28 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDJNL4d3cb983615d: Fix deserialization of extra_headers..