Updating bd925475..6b467dd4
Fast-forward
 sql/upgrades/160.sql               | 41 ++++++++++++++++++++++++++++++++++++++
 swh/storage/converters.py          |  6 +++++-
 swh/storage/sql/30-swh-schema.sql  |  2 +-
 swh/storage/sql/60-swh-indexes.sql | 22 ++++++++++++++++++++
 4 files changed, 69 insertions(+), 2 deletions(-)
 create mode 100644 sql/upgrades/160.sql

Changes applied before test

commit 6b467dd4c12827a5d1ed347d3edcd079e4c03724
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 19 14:06:21 2020 +0200

    converters: convert neg_utc_offset to False if it is None.

commit 131d156469724e07dd34efc5a47873c1b63097f5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 19 12:40:01 2020 +0200

    pg: Make date_neg_utc_offset is not null if date is not null.
    
    Fixes a regression in 038a219f84d6b8a4f02b48f9ad3c5d823d097790,
    as it made converters expect a boolean.
    
    We stopped writing this kind of nulls since we started using model
    objects for insertions, but didn't migrate existing data.
    
    This commit migrates these nulls to false, then adds a constraint
    to enforce it in the future.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/820/ for more details.

Harbormaster completed remote builds in B14670: Diff 13406.Aug 19 2020, 2:11 PM

anlambert accepted this revision.Aug 19 2020, 2:12 PM

This revision is now accepted and ready to land.Aug 19 2020, 2:12 PM

rebase

Build is green

Patch application report for D3803 (id=13411)

Could not rebase; Attempt merge onto bd925475d9...

Updating bd925475..7dcd5708
Fast-forward
 swh/storage/backfill.py   | 1 +
 swh/storage/converters.py | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

Changes applied before test

commit 7dcd5708b0cffdacd0082288262ccc4d78cec2de
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 19 14:06:21 2020 +0200

    converters: convert neg_utc_offset to False if it is None.

commit e2f066549123f069bf0ae34d593038ffd834d9c4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 19 14:54:45 2020 +0200

    backfiller: Add missing 'extra_header' field.
    
    This field wasn't backfilled; and it wasn't caught by tests, because
    revisions in swh.journal.tests.journal_data.TEST_OBJECTS were had
    an empty extra_header field.
    
    Starting with swh-journal v0.4.3, one of the revisions in TEST_OBJECTS
    has a non-empty extra_header field, so it will become a test failure
    without this commit

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/824/ for more details.

Harbormaster completed remote builds in B14675: Diff 13411.Aug 19 2020, 3:05 PM

Closed by commit rDSTO7dcd5708b0cf: converters: convert neg_utc_offset to False if it is None. (authored by vlorentz). · Explain WhyAug 20 2020, 8:51 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO7dcd5708b0cf: converters: convert neg_utc_offset to False if it is None..