Differential D3793

model: Raise error on naive datetimes.
ClosedPublic
Actions

Authored by vlorentz on Aug 14 2020, 2:13 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDMOD6dd6acecc829: model: Raise error on naive datetimes.

Summary

We may unknowingly pass naive datetimes to the storage through them,
causing the underlying DB to assign them a timezone that might not match
the actual one.

It already happens in swh.model and swh.loader.package tests.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 14 2020, 2:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 14 2020, 2:13 PM

Build is green

Patch application report for D3793 (id=13312)

Rebasing onto d1db7b9954...

Current branch diff-target is up to date.

Changes applied before test

commit 6dd6acecc8297f8c9f77bdae0ccd291ceabdfd8e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 14 14:12:29 2020 +0200

    model: Raise error on naive datetimes.
    
    We may unknowingly pass naive datetimes to the storage through them,
    causing the underlying DB to assign them a timezone that might not match
    the actual one.
    
    It already happens in swh.model and swh.loader.package tests.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/132/ for more details.

Harbormaster completed remote builds in B14575: Diff 13312.Aug 14 2020, 2:14 PM