Page MenuHomeSoftware Heritage

cassandra: Make origin_visit_get_latest filter using any status of a visit, instead of just the last.
ClosedPublic

Authored by vlorentz on Aug 12 2020, 8:40 PM.

Details

Summary

This fixes a mismatch in behavior with the pg and the in-mem storages

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3784 (id=13271)

Could not rebase; Attempt merge onto 6675286c4f...

Updating 6675286c..dd320a63
Fast-forward
 swh/storage/cassandra/storage.py  | 45 ++++++++++++++++---------------
 swh/storage/tests/test_storage.py | 56 ++++++++++++++++++++++++++++++++++++++-
 2 files changed, 78 insertions(+), 23 deletions(-)
Changes applied before test
commit dd320a63b32b0e79c6f90a83236d607093219359
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 12 20:25:23 2020 +0200

    cassandra: Make origin_visit_get_latest filter using any status of a visit, instead of just the last.
    
    This fixes a mismatch in behavior with the pg and the in-mem storages

commit 1d45c5a0debc2e45ceee5effe565aab36905eb1c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 12 19:08:17 2020 +0200

    cassandra: Fix wrong algo reported in HashCollision, because of variable shadowing.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/756/ for more details.

This revision is now accepted and ready to land.Aug 14 2020, 2:47 PM

Build is green

Patch application report for D3784 (id=13318)

Could not rebase; Attempt merge onto 6675286c4f...

Updating 6675286c..3dc69aaa
Fast-forward
 swh/storage/cassandra/storage.py  | 47 ++++++++++++++--------------
 swh/storage/tests/test_storage.py | 66 ++++++++++++++++++++++++++++++++++++---
 2 files changed, 86 insertions(+), 27 deletions(-)
Changes applied before test
commit 3dc69aaa42e76e373c4d23c1e8d98af5a804970f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 12 20:25:23 2020 +0200

    cassandra: Make origin_visit_get_latest filter using any status of a visit, instead of just the last.
    
    This fixes a mismatch in behavior with the pg and the in-mem storages

commit 006eeecaba7523f407fa0e253d6c832ea246d959
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 12 19:08:17 2020 +0200

    cassandra: Fix wrong algo reported in HashCollision, because of variable shadowing.

commit da287313765da62d34dc0dca7c22dbd61f40504f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 14 15:15:54 2020 +0200

    cassandra: Fix content_missing_per_sha1 when its parameter has length != 1.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/790/ for more details.