Differential D3746

package.loader: Log failed branches report at the end of the task
ClosedPublic
Actions

Authored by ardumont on Aug 8 2020, 10:08 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDBASEe3a9d5a89e20: package.loader: Log a failure summary report at the end of the task

Summary

Proposal ;)

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 14461
Build 22239: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22238: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 8 2020, 10:08 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 8 2020, 10:08 AM

Build is green

Patch application report for D3746 (id=13194)

Could not rebase; Attempt merge onto fc9fe58d65...

Updating fc9fe58..64c24cb
Fast-forward
 swh/loader/package/loader.py                     |  9 ++++
 swh/loader/package/nixguix/loader.py             | 33 ++++++++++----
 swh/loader/package/nixguix/tests/conftest.py     | 36 +++++++++++++++
 swh/loader/package/nixguix/tests/test_nixguix.py | 58 +++++++++++++++++-------
 4 files changed, 110 insertions(+), 26 deletions(-)
 create mode 100644 swh/loader/package/nixguix/tests/conftest.py

Changes applied before test

commit 64c24cb4872357cb96ff60cacef0a7570137f524
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Aug 8 10:06:48 2020 +0200

    package.loader: Propose a failure summary report at the end of the task

commit 8dc56df25fe19994b5b026975b8ae4d60a356c3c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Aug 8 08:53:15 2020 +0200

    nixguix: Make the unsupported artifact extensions configurable
    
    So the maintenance is easier (not necessarily code to package and deploy).

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/271/ for more details.

Harbormaster completed remote builds in B14460: Diff 13194.Aug 8 2020, 10:09 AM

vlorentz added a subscriber: vlorentz.Aug 8 2020, 10:38 AM

vlorentz added inline comments.

swh/loader/package/loader.py
364–369	that's a weird way to put it imo. What about this? logger.warning( "%d failed branches: %s", len(failed_branches), failed_branches, )

ardumont added inline comments.Aug 8 2020, 12:41 PM

swh/loader/package/loader.py
364–369	yeah, i'm biased. I did it so one does not have to scroll too much backwards (if the list of failed branches is large, which i expect it to be for the nixguix loader right now at least ;)

Rework commit message
Rework log message as suggested

Build is green

Patch application report for D3746 (id=13195)

Rebasing onto fc9fe58d65...

Current branch diff-target is up to date.

Changes applied before test

commit e3a9d5a89e2047117065af4554d917001f2f3630
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Aug 8 10:06:48 2020 +0200

    package.loader: Log a failure summary report at the end of the task

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/272/ for more details.

Harbormaster completed remote builds in B14461: Diff 13195.Aug 8 2020, 12:59 PM

ardumont retitled this revision from package.loader: Propose a failure summary report at the end of the task to package.loader: Log failed branches report at the end of the task.Aug 8 2020, 1:00 PM

ardumont mentioned this in T2485: staging: Running nixguix on guix sources .Aug 8 2020, 1:23 PM

vlorentz accepted this revision.Aug 8 2020, 1:37 PM

This revision is now accepted and ready to land.Aug 8 2020, 1:37 PM

Closed by commit rDLDBASEe3a9d5a89e20: package.loader: Log a failure summary report at the end of the task (authored by ardumont). · Explain WhyAug 8 2020, 2:46 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEe3a9d5a89e20: package.loader: Log a failure summary report at the end of the task.