Differential D3744

swh.loader.tests: Use snapshot_get_all_branches in check_snapshot
ClosedPublic
Actions

Authored by ardumont on Aug 7 2020, 9:59 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDBASEd9e4365f6f29: swh.loader.tests: Use snapshot_get_all_branches in check_snapshot

Summary

This migrates to stop using old snapshot-get.
This allows to use more Snapshot objects for checks!

This also fixes build [1]

[1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/1035/console

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 7 2020, 9:59 PM

ardumont mentioned this in D3742: nixguix: Filter out unsupported artifact extensions.

Build is green

Patch application report for D3744 (id=13187)

Rebasing onto 57d3e372fa...

Current branch diff-target is up to date.

Changes applied before test

commit d9e4365f6f2998354c3128f1a69e014da8976ed8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Aug 7 21:45:15 2020 +0200

    swh.loader.tests: Use snapshot_get_all_branches in check_snapshot
    
    Fixes build [1]
    
    [1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/1035/console

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/267/ for more details.

Harbormaster completed remote builds in B14453: Diff 13187.Aug 7 2020, 10:00 PM

vlorentz accepted this revision.Aug 7 2020, 10:02 PM

This revision is now accepted and ready to land.Aug 7 2020, 10:02 PM

Closed by commit rDLDBASEd9e4365f6f29: swh.loader.tests: Use snapshot_get_all_branches in check_snapshot (authored by ardumont). · Explain WhyAug 7 2020, 10:55 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEd9e4365f6f29: swh.loader.tests: Use snapshot_get_all_branches in check_snapshot.