Differential D3743

pg: Fix crash in snapshot_get when the snapshot does not exist.
ClosedPublic
Actions

Authored by vlorentz on Aug 7 2020, 9:46 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTObdd2f4a1eccd: pg: Fix crash in snapshot_get when the snapshot does not exist.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 7 2020, 9:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 7 2020, 9:46 PM

Build is green

Patch application report for D3743 (id=13186)

Rebasing onto 4918759fc8...

Current branch diff-target is up to date.

Changes applied before test

commit 70a8ee4a518fb379833158833f9d334abea5a7a4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 7 21:46:29 2020 +0200

    pg: Fix crash in snapshot_get when the snapshot does not exist.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/718/ for more details.

Harbormaster completed remote builds in B14452: Diff 13186.Aug 7 2020, 9:51 PM

ok but following your footsteps, it's missing a test, isn't it?

ardumont accepted this revision.Aug 7 2020, 9:55 PM

This revision is now accepted and ready to land.Aug 7 2020, 9:55 PM

yeah, but I'll remove it next week D:

Closed by commit rDSTObdd2f4a1eccd: pg: Fix crash in snapshot_get when the snapshot does not exist. (authored by vlorentz). · Explain WhyAug 7 2020, 10:02 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTObdd2f4a1eccd: pg: Fix crash in snapshot_get when the snapshot does not exist..

Revision Contents
Changeset List

Path

Size

swh/

storage/

storage.py

2 lines

Diff 13189

View Options

pg: Fix crash in snapshot_get when the snapshot does not exist.ClosedPublicActions