Differential D3734

indexer.rehash: Adapt content_get_metadata call to content_get
ClosedPublic
Actions

Authored by ardumont on Aug 7 2020, 12:53 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDCIDXe45d76d12dd8: indexer.rehash: Adapt content_get_metadata call to content_get

Summary

Related to T645

Test Plan

tox
(failing until storage release > 0.12)

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14437
Build 22201: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22200: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 7 2020, 12:53 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 7 2020, 12:53 AM

Build has FAILED

Patch application report for D3734 (id=13140)

Rebasing onto 26ea0e1f30...

Current branch diff-target is up to date.

Changes applied before test

commit 944a010ab6875516724e27a17681c4c521e7c8e5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Aug 7 00:53:40 2020 +0200

    indexer.rehash: Adapt content_get_metadata call to content_get
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/37/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/37/console

Harbormaster failed remote builds in B14406: Diff 13140!Aug 7 2020, 12:54 AM

ardumont edited the test plan for this revision. (Show Details)Aug 7 2020, 12:54 AM

ardumont mentioned this in D3733: storage*: Rename and type content_get(List[Sha1]) -> List[Optional[Content]].

Explain in the commit message it's because the endpoint was renamed

This revision is now accepted and ready to land.Aug 7 2020, 9:35 AM

Explain in commit message

Explain in the commit message

Build is green

Patch application report for D3734 (id=13174)

Rebasing onto 26ea0e1f30...

Current branch diff-target is up to date.

Changes applied before test

commit e45d76d12dd8d77aadae29d3eabf1e9251b32bc6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Aug 7 00:53:40 2020 +0200

    indexer.rehash: Adapt content_get_metadata call to content_get
    
    `content_get_metadata` got renamed to `content_get` and its type got improved.
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/38/ for more details.

Harbormaster completed remote builds in B14440: Diff 13174.Aug 7 2020, 2:59 PM

Closed by commit rDCIDXe45d76d12dd8: indexer.rehash: Adapt content_get_metadata call to content_get (authored by ardumont). · Explain WhyAug 7 2020, 3:00 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDXe45d76d12dd8: indexer.rehash: Adapt content_get_metadata call to content_get.

Build is green

Patch application report for D3734 (id=13171)

Could not rebase; Attempt merge onto 8029d68735...

Updating 8029d687..478a7acb
Fast-forward
 swh/web/common/service.py                  | 19 +++++++-------
 swh/web/tests/api/views/test_content.py    |  6 ++---
 swh/web/tests/browse/views/test_content.py |  9 +++----
 swh/web/tests/common/test_service.py       | 16 +++++++-----
 swh/web/tests/conftest.py                  | 21 +++++++++------
 swh/web/tests/data.py                      | 41 +++++++++++++++++-------------
 swh/web/tests/strategies.py                |  4 +--
 7 files changed, 63 insertions(+), 53 deletions(-)

Changes applied before test

commit 478a7acb46e0ae1e7199fcb58363f6e4020eb6c7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Aug 7 06:39:56 2020 +0200

    Adapt type and rename content_get_metadata calls to content_get
    
    Related to T645

commit 5fb903850c4d6c66925f805a6a541477f9949133
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:46:42 2020 +0200

    Rename content_get calls to content_get_data
    
    According to the latest change in storage

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/315/ for more details.

Harbormaster completed remote builds in B14437: Diff 13171.Aug 7 2020, 3:03 PM