Page MenuHomeSoftware Heritage
Differential D3729

npm: Fix assertion to use the correct storage api
ClosedPublic
Actions

Authored by ardumont on Aug 6 2020, 11:13 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDBASEbc793c177606: npm: Fix assertion to use the correct storage api
Summary

content_get is/was [1] about the raw content not the content itself...

[1] it's getting renamed in D3728

Test Plan

tox

Diff Detail

Event Timeline

ardumont created this revision.Aug 6 2020, 11:13 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2020, 11:13 PM
swh-public-ci added a comment.Aug 6 2020, 11:14 PM

Build is green

Patch application report for D3729 (id=13133)

Rebasing onto b0dd6219fb...

Current branch diff-target is up to date.
Changes applied before test
commit bc793c1776067c187a9951c4cf954a88884a4f13
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:12:32 2020 +0200

    npm: Fix assertion to use the correct storage api

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/260/ for more details.

Harbormaster completed remote builds in B14399: Diff 13133.Aug 6 2020, 11:14 PM
ardumont edited the summary of this revision. (Show Details)Aug 6 2020, 11:24 PM
ardumont mentioned this in D3728: storage*: Rename and type content_get_data(Sha1) -> Optional[bytes].Aug 7 2020, 12:44 AM
vlorentz accepted this revision.Aug 7 2020, 9:24 AM
vlorentz added a subscriber: vlorentz.

both ways are correct imo

This revision is now accepted and ready to land.Aug 7 2020, 9:24 AM
Closed by commit rDLDBASEbc793c177606: npm: Fix assertion to use the correct storage api (authored by ardumont). · Explain WhyAug 7 2020, 12:40 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDBASEbc793c177606: npm: Fix assertion to use the correct storage api.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
loader/
package/
npm/
tests/
6 lines98%
Loading...

Diff 13133

View Options

swh/loader/package/npm/tests/test_npm.py

Loading...
About · Developer information · Legal