Differential D3717

Adapt code according to storage signature
ClosedPublic
Actions

Authored by ardumont on Aug 6 2020, 9:46 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2517: Add remaining missing types to swh.storage.interface

Commits

rDLDG178b9f5061f9: Adapt code according to storage signature

Summary

Fixes build [1]

[1] https://jenkins.softwareheritage.org/job/DLDG/job/tests/768/console

Related to T2517

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 6 2020, 9:46 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2020, 9:46 AM

Build is green

Patch application report for D3717 (id=13097)

Rebasing onto 7530e324d4...

Current branch diff-target is up to date.

Changes applied before test

commit 13aa04fbdebe2649dfd0f1b92f26faaf32820e06
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 09:46:22 2020 +0200

    Adapt code according to storage type contract
    
    Related to T2517

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/53/ for more details.

Harbormaster completed remote builds in B14347: Diff 13097.Aug 6 2020, 9:47 AM

s/type contract/return type/

This revision is now accepted and ready to land.Aug 6 2020, 10:26 AM

ardumont retitled this revision from Adapt code according to storage type contract to Adapt code according to storage signature.Aug 6 2020, 10:26 AM

Rework commit message

Build is green

Patch application report for D3717 (id=13102)

Rebasing onto 7530e324d4...

Current branch diff-target is up to date.

Changes applied before test

commit 178b9f5061f9b47b2f4e58fa657aabc23ae22f17
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 09:46:22 2020 +0200

    Adapt code according to storage signature
    
    Fixes build [1]
    
    [1] https://jenkins.softwareheritage.org/job/DLDG/job/tests/768/console
    
    Related to T2517

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/54/ for more details.

Harbormaster completed remote builds in B14352: Diff 13102.Aug 6 2020, 10:30 AM

Closed by commit rDLDG178b9f5061f9: Adapt code according to storage signature (authored by ardumont). · Explain WhyAug 6 2020, 10:32 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDG178b9f5061f9: Adapt code according to storage signature.