Related to T2517
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Maniphest Tasks
- T2517: Add remaining missing types to swh.storage.interface
- Commits
- rDSTO472266327843: storage*: object_find_by_sha1_git: Type remaining existing endpoints
tox
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3711 (id=13077)
Could not rebase; Attempt merge onto 7dbd64d913...
Updating 7dbd64d9..47226632 Fast-forward swh/storage/cassandra/storage.py | 34 ++++++++++++++++------------ swh/storage/in_memory.py | 30 +++++++++++++++---------- swh/storage/interface.py | 48 ++++++++++++++++++++++++---------------- swh/storage/storage.py | 33 +++++++++++++++++---------- 4 files changed, 88 insertions(+), 57 deletions(-)
Changes applied before test
commit 472266327843b873d0541e0aa9b948d907521965 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Aug 5 12:56:51 2020 +0200 storage*: object_find_by_sha1_git: Type remaining existing endpoints Related to T2517 commit 334a016e44c3cd590d394d84b69db724991babf0 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Aug 5 12:47:46 2020 +0200 storage*: snapshot_get_branches: Type remaining existing endpoints Related to T2517 commit 27c7f078601fbc3eca99ea47de742c3a6cd58005 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Aug 5 12:35:31 2020 +0200 storage*: snapshot_count_branches: Type remaining existing endpoints Related to T2517 commit ec620affab35950a5c34e42a49e968324f4f440c Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Aug 5 12:29:24 2020 +0200 storage*: snapshot_get_by_origin_visit: Type remaining existing endpoints Related to T2517 commit 7c6c08893b301215978c9d2482b3a432fffd716e Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Aug 5 12:23:47 2020 +0200 storage*: snapshot_get: Type remaining existing endpoints Related to T2517 commit ec4aed45bebe95c5a0cad0c10b8fd01f3dc86391 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Aug 5 12:12:05 2020 +0200 storage*: snapshot_missing: Type remaining existing endpoints Related to T2517
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/695/ for more details.
swh/storage/in_memory.py | ||
---|---|---|
697 | Dict[Sha1Git, List[Dict]] => Dict[Sha1Git, List[Dict[str, Any]] ? |
swh/storage/in_memory.py | ||
---|---|---|
697 | yeah, i thought it was a mouthful so i did not add it. |
swh/storage/in_memory.py | ||
---|---|---|
697 | Right, this will be replaced by model objects. No need to bother then. |