Differential D3710

storage: snapshot_: Type remaining existing endpoints
ClosedPublic
Actions

Authored by ardumont on Aug 5 2020, 12:50 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2517: Add remaining missing types to swh.storage.interface

Commits

rDSTO334a016e44c3: storage*: snapshot_get_branches: Type remaining existing endpoints
rDSTO27c7f078601f: storage*: snapshot_count_branches: Type remaining existing endpoints
rDSTOec620affab35: storage*: snapshot_get_by_origin_visit: Type remaining existing endpoints
rDSTO7c6c08893b30: storage*: snapshot_get: Type remaining existing endpoints
rDSTOec4aed45bebe: storage*: snapshot_missing: Type remaining existing endpoints

Summary

endpoints:

snapshot_missing
snapshot_get
snapshot_get_by_origin_visit
snapshot_count_branches
snapshot_get_branches

(5 commits)

Related to T2517

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 5 2020, 12:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 5 2020, 12:50 PM

ardumont edited the summary of this revision. (Show Details)Aug 5 2020, 12:51 PM

Build is green

Patch application report for D3710 (id=13076)

Rebasing onto 7dbd64d913...

Current branch diff-target is up to date.

Changes applied before test

commit 334a016e44c3cd590d394d84b69db724991babf0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 12:47:46 2020 +0200

    storage*: snapshot_get_branches: Type remaining existing endpoints
    
    Related to T2517

commit 27c7f078601fbc3eca99ea47de742c3a6cd58005
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 12:35:31 2020 +0200

    storage*: snapshot_count_branches: Type remaining existing endpoints
    
    Related to T2517

commit ec620affab35950a5c34e42a49e968324f4f440c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 12:29:24 2020 +0200

    storage*: snapshot_get_by_origin_visit: Type remaining existing endpoints
    
    Related to T2517

commit 7c6c08893b301215978c9d2482b3a432fffd716e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 12:23:47 2020 +0200

    storage*: snapshot_get: Type remaining existing endpoints
    
    Related to T2517

commit ec4aed45bebe95c5a0cad0c10b8fd01f3dc86391
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 12:12:05 2020 +0200

    storage*: snapshot_missing: Type remaining existing endpoints
    
    Related to T2517

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/694/ for more details.

Harbormaster completed remote builds in B14319: Diff 13076.Aug 5 2020, 12:55 PM

vlorentz accepted this revision.Aug 5 2020, 2:39 PM

This revision is now accepted and ready to land.Aug 5 2020, 2:39 PM

Closed by commit rDSTOec4aed45bebe: storage*: snapshot_missing: Type remaining existing endpoints (authored by ardumont). · Explain WhyAug 5 2020, 2:49 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOec4aed45bebe: storage*: snapshot_missing: Type remaining existing endpoints.

ardumont added a commit: rDSTO7c6c08893b30: storage*: snapshot_get: Type remaining existing endpoints.

ardumont added a commit: rDSTOec620affab35: storage*: snapshot_get_by_origin_visit: Type remaining existing endpoints.

ardumont added a commit: rDSTO27c7f078601f: storage*: snapshot_count_branches: Type remaining existing endpoints.

ardumont added a commit: rDSTO334a016e44c3: storage*: snapshot_get_branches: Type remaining existing endpoints.