Last origin endpoint. I'll change it soon to return origin objects.
But let's type remaining as is for now.
Related to T645
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T2517: Add remaining missing types to swh.storage.interface
- Commits
- rDSTOc32e224d2399: storage*: origin_get_by_sha1: Type remaining existing endpoints
tox
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3698 (id=13029)
Could not rebase; Attempt merge onto a5232b7a7b...
Updating a5232b7a..8d740295 Fast-forward swh/storage/cassandra/storage.py | 2 +- swh/storage/in_memory.py | 9 ++++++--- swh/storage/interface.py | 14 +++++++------- swh/storage/storage.py | 6 ++++-- 4 files changed, 18 insertions(+), 13 deletions(-)
Changes applied before test
commit 8d7402954e16a8b1e2a3b3f8b6bd0547ba3995e6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue Aug 4 17:59:46 2020 +0200
storage*: origin_get_by_sha1: Type remaining existing endpoints
Related to T645
commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue Aug 4 17:59:24 2020 +0200
storage*: check_config: Type remaining existing endpoints
Related to T645Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/666/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/666/console
| swh/storage/in_memory.py | ||
|---|---|---|
| 676 | ardu: -> List !!! | |
| swh/storage/in_memory.py | ||
|---|---|---|
| 676 | ah yeah, not now, it's yielding here. | |
Comment Actions
Build is green
Patch application report for D3698 (id=13030)
Could not rebase; Attempt merge onto a5232b7a7b...
Updating a5232b7a..c32e224d Fast-forward swh/storage/cassandra/storage.py | 12 ++++++------ swh/storage/in_memory.py | 9 ++++++--- swh/storage/interface.py | 14 +++++++------- swh/storage/storage.py | 6 ++++-- 4 files changed, 23 insertions(+), 18 deletions(-)
Changes applied before test
commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue Aug 4 17:59:46 2020 +0200
storage*: origin_get_by_sha1: Type remaining existing endpoints
Related to T645
commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue Aug 4 17:59:24 2020 +0200
storage*: check_config: Type remaining existing endpoints
Related to T645See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/667/ for more details.
| swh/storage/in_memory.py | ||
|---|---|---|
| 677–678 | why this change? We should move toward returning lists, so that's a step backward | |
| swh/storage/in_memory.py | ||
|---|---|---|
| 677–678 | well, i'm aligning with what the production does (pg).
no, that's not running anywhere besides test. I can probably change towards what you say though. | |
| swh/storage/in_memory.py | ||
|---|---|---|
| 677–678 |
The signature also matches if you return a list, because lists are iterables. | |
Comment Actions
To avoid too much hassle with git/arc/jenkins (this is a base root of my other changes/diff you accepted...), i'll commit this as is and improve as you suggest in another diff if you don't mind [1]
[1] D3708