Page MenuHomeSoftware Heritage

Make retrieve_sources use generic api_info instead of duplicating its code.
ClosedPublic

Authored by vlorentz on Fri, Jul 31, 3:27 PM.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Fri, Jul 31, 3:27 PM

Build is green

Patch application report for D3673 (id=12924)

Could not rebase; Attempt merge onto d982889286...

Updating d982889..8988360
Fast-forward
 swh/loader/package/loader.py                     | 48 ++++++++++++++++++
 swh/loader/package/nixguix/loader.py             | 39 +++++++++++----
 swh/loader/package/nixguix/tests/test_nixguix.py | 62 ++++++++++++++++++++++--
 swh/loader/package/nixguix/tests/test_tasks.py   | 10 ++--
 swh/loader/package/npm/loader.py                 |  2 +-
 swh/loader/package/pypi/loader.py                |  5 +-
 swh/loader/package/tests/test_utils.py           |  5 +-
 swh/loader/package/utils.py                      |  8 +--
 swh/loader/tests/__init__.py                     |  1 +
 9 files changed, 152 insertions(+), 28 deletions(-)
Changes applied before test
commit 8988360d7a11f3fd0deef7a552b8ad68c681a68f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 31 14:50:44 2020 +0200

    Make retrieve_sources use generic api_info instead of duplicating its code.

commit 55436f3925bf2a0e37eb3a5f2a60fb98fd7c80fe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 31 13:15:34 2020 +0200

    nixguix: Load the content of sources.json as extrinsic snapshot metadata.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/236/ for more details.

ardumont accepted this revision.Fri, Jul 31, 3:34 PM
ardumont added a subscriber: ardumont.

looks good. couple of nits on copyright headers...

thanks.

swh/loader/package/pypi/loader.py
1

copyright...

swh/loader/package/tests/test_utils.py
1

copyright

This revision is now accepted and ready to land.Fri, Jul 31, 3:34 PM
vlorentz updated this revision to Diff 12927.Fri, Jul 31, 3:45 PM

update copyright

This revision was landed with ongoing or failed builds.Fri, Jul 31, 3:45 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D3673 (id=12927)

Rebasing onto c510d10d23...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-237-D3673.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/237/ for more details.