Differential D3669

Reuse swh.core stream_results function
ClosedPublic
Actions

Authored by ardumont on Jul 31 2020, 1:58 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDSTO3466e48be8c5: Reuse swh.core stream_results function

Summary

Related to T645

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14146
Build 21735: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21734: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	14,246 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_backfill::test_backfiller swh_storage_backend_config = {'cls': 'local', 'db': 'postgresql://postgres@127.0.0.1:21976/tests', 'journal_writer': {'brokers': ['127.0.0.1:38781'], 'client_id': 'kafka_writer-1', 'cls': 'kafka', 'prefix': 'wiksmogvab-1'}, 'objstorage': {'args': {}, 'cls': 'memory'}} kafka_prefix = 'wiksmogvab', kafka_consumer_group = 'test-consumer-wiksmogvab' kafka_server = '127.0.0.1:38781'
	3,012 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_kafka_writer::test_storage_direct_writer kafka_prefix = 'pobaxjiqxo', kafka_server = '127.0.0.1:38781' consumer = <cimpl.Consumer object at 0x7f09566c6d90>
	11,225 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_kafka_writer::test_storage_direct_writer_anonymized kafka_prefix = 'serjsgwvxs', kafka_server = '127.0.0.1:38781' consumer = <cimpl.Consumer object at 0x7f09566c6e18>
	12,012 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_replay::test_storage_play_with_collision replayer_storage_and_client = (<swh.storage.in_memory.InMemoryStorage object at 0x7f0956687550>, <swh.journal.client.JournalClient object at 0x7f095665abe0>) caplog = <_pytest.logging.LogCaptureFixture object at 0x7f09566b0a90>
	6 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_content
		View Full Test Results (4 Failed · 749 Passed · 17 Skipped)

Event Timeline

ardumont created this revision.Jul 31 2020, 1:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 31 2020, 1:58 PM

Build has FAILED

Patch application report for D3669 (id=12908)

Rebasing onto cf9f44e805...

Current branch diff-target is up to date.

Changes applied before test

commit 04c0f04913ef9c9f40e23e69eb728d122ac6a53e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 31 13:56:46 2020 +0200

    Reuse swh.core stream_results function
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/639/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/639/console

Harbormaster failed remote builds in B14146: Diff 12908!Jul 31 2020, 2:05 PM

vlorentz accepted this revision.Jul 31 2020, 2:15 PM

This revision is now accepted and ready to land.Jul 31 2020, 2:15 PM

Rebase

Build is green

Patch application report for D3669 (id=12917)

Rebasing onto 0eb309e02d...

Current branch diff-target is up to date.

Changes applied before test

commit 3466e48be8c5a8721f88d6fa6713f2cbd291eed4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 31 13:56:46 2020 +0200

    Reuse swh.core stream_results function
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/641/ for more details.

Harbormaster completed remote builds in B14155: Diff 12917.Jul 31 2020, 2:54 PM

Closed by commit rDSTO3466e48be8c5: Reuse swh.core stream_results function (authored by ardumont). · Explain WhyJul 31 2020, 2:56 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO3466e48be8c5: Reuse swh.core stream_results function.