Differential D3655

package.loader: Fix type warning with swh.core > 0.2.0
ClosedPublic
Actions

Authored by vlorentz on Jul 30 2020, 7:05 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE8808b7563a78: package.loader: Fix type warning with swh.core > 0.2.0

Summary

The next version of swh.core will allow mypy to detect the return
type of origin_visit_add is Iterable.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 30 2020, 7:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 30 2020, 7:05 PM

Build is green

Patch application report for D3655 (id=12869)

Rebasing onto 30556901ae...

Current branch diff-target is up to date.

Changes applied before test

commit 8808b7563a78f74e23795ed684c7445feb8dc6e1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 30 11:10:53 2020 +0200

    package.loader: Fix type warning with swh.core > 0.2.0
    
    The next version of swh.core will allow mypy to detect the return
    type of origin_visit_add is Iterable.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/228/ for more details.

Harbormaster completed remote builds in B14106: Diff 12869.Jul 30 2020, 7:07 PM