Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDJNLdf96acf334b6: Add support for MetadataAuthority, MetadataFetcher, and RawExtrinsicMetadata.
Diff Detail
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3654 (id=12868)
Could not rebase; Attempt merge onto bf35ea79d3...
Updating bf35ea7..df96acf Fast-forward swh/journal/pytest_plugin.py | 17 +- swh/journal/serializers.py | 48 +++- swh/journal/tests/journal_data.py | 483 +++++++++++++++++--------------- swh/journal/tests/test_pytest_plugin.py | 3 + 4 files changed, 305 insertions(+), 246 deletions(-)
Changes applied before test
commit df96acf334b664def773d69fc1bf5e4510985670 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Jul 30 17:36:43 2020 +0200 Add support for MetadataAuthority, MetadataFetcher, and RawExtrinsicMetadata. commit 627f3ab8598d5a7cc90fe4b1388e8ee48222c41f Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Jul 30 16:56:47 2020 +0200 Remove TEST_OBJECT_DICTS, use only TEST_OBJECTS. TEST_OBJECT_DICTS isn't used in any other package.
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/106/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/106/console
swh/journal/serializers.py | ||
---|---|---|
75 | why don't we use the object_.object_type here? (I assume object_ is a BaseModel object). Yeah, out of the scope of this new objects adding though. |
swh/journal/serializers.py | ||
---|---|---|
75 | because it didn't exist when this code was written ^^ |