Differential D3653

Add missing object_type class attributes on MetadataAuthority, MetadataFetcher, and RawExtrinsicMetadata.
ClosedPublic
Actions

Authored by vlorentz on Jul 30 2020, 5:26 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Summary

Needed by the journal

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14104
Build 21660: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21659: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 30 2020, 5:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 30 2020, 5:26 PM

Build is green

Patch application report for D3653 (id=12867)

Rebasing onto f9fc1062bb...

Current branch diff-target is up to date.

Changes applied before test

commit 08632e7fd685caff11596d2e054d0122fe5ba541
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 30 17:25:49 2020 +0200

    Add missing object_type class attributes on MetadataAuthority, MetadataFetcher, and RawExtrinsicMetadata.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/126/ for more details.

Harbormaster completed remote builds in B14104: Diff 12867.Jul 30 2020, 5:28 PM

ardumont accepted this revision.Jul 30 2020, 5:55 PM

This revision is now accepted and ready to land.Jul 30 2020, 5:55 PM

Don't we have a test for that btw?

if we do, I can't find it

08632e7fd685caff11596d2e054d0122fe5ba541

vlorentz mentioned this in D3727: model: Add final object_type field on metadata related model objects.Aug 6 2020, 7:14 PM