Page MenuHomeSoftware Heritage

Remove TEST_OBJECT_DICTS, use only TEST_OBJECTS.
ClosedPublic

Authored by vlorentz on Thu, Jul 30, 4:56 PM.

Details

Summary

TEST_OBJECT_DICTS isn't used in any other package.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Thu, Jul 30, 4:56 PM

Build is green

Patch application report for D3652 (id=12863)

Rebasing onto bf35ea79d3...

Current branch diff-target is up to date.
Changes applied before test
commit 8f80f162c98da2b4721c84addfdf994fe7cb4610
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 30 16:56:47 2020 +0200

    Remove TEST_OBJECT_DICTS, use only TEST_OBJECTS.
    
    TEST_OBJECT_DICTS isn't used in any other package.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/104/ for more details.

vlorentz updated this revision to Diff 12865.Thu, Jul 30, 5:02 PM

also remove MODEL_CLASSES

Build is green

Patch application report for D3652 (id=12865)

Rebasing onto bf35ea79d3...

Current branch diff-target is up to date.
Changes applied before test
commit 627f3ab8598d5a7cc90fe4b1388e8ee48222c41f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 30 16:56:47 2020 +0200

    Remove TEST_OBJECT_DICTS, use only TEST_OBJECTS.
    
    TEST_OBJECT_DICTS isn't used in any other package.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/105/ for more details.

ardumont accepted this revision.Fri, Jul 31, 10:22 AM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/journal/tests/journal_data.py
42–43

I did not realize we could create consistent content like this, nice ;)

291

why Sequence here (picture me curious)?

This revision is now accepted and ready to land.Fri, Jul 31, 10:22 AM
vlorentz added inline comments.Fri, Jul 31, 10:24 AM
swh/journal/tests/journal_data.py
291

something something covariance

This revision was automatically updated to reflect the committed changes.