Page MenuHomeSoftware Heritage

in_memory: fix tie-breaking when two visits have the same date.
ClosedPublic

Authored by vlorentz on Tue, Jul 28, 9:41 AM.

Details

Summary

swh-loader-core's tests depend on this behavior.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Tue, Jul 28, 9:41 AM
ardumont accepted this revision.EditedTue, Jul 28, 9:42 AM
ardumont added a subscriber: ardumont.

Thanks for the fix.

Nice regression i think got introduced in D3620.

Thank you swh-loader-core!!

This revision is now accepted and ready to land.Tue, Jul 28, 9:42 AM

Build is green

Patch application report for D3628 (id=12769)

Rebasing onto 119d01e416...

First, rewinding head to replay your work on top of it...
Applying: in_memory: fix tie-breaking when two visits have the same date.
Changes applied before test
commit d4a1f25753897a2e6407c621dfd4dd1e7c60e5bb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 28 09:40:57 2020 +0200

    in_memory: fix tie-breaking when two visits have the same date.
    
    swh-loader-core's tests depend on this behavior.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/578/ for more details.

This revision was landed with ongoing or failed builds.Tue, Jul 28, 9:55 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D3628 (id=12770)

Rebasing onto 77960ca4b5...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-579-D3628.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/579/ for more details.