The benefits are minimal for now, as 'raw' still contains a lot of stuff;
but further commits will move data out of 'raw' to a proper attribute.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDLDBASE1050d94d871d: Use an attr class for p_info instead of a dict.
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13910 Build 21335: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 21334: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/204/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/204/console
Comment Actions
Build is green
Patch application report for D3602 (id=12688)
Could not rebase; Attempt merge onto 2699a1f629...
Updating 2699a1f..6890273 Fast-forward swh/loader/cli.py | 10 +++++-- swh/loader/package/archive/loader.py | 25 ++++++++++------- swh/loader/package/cran/loader.py | 24 ++++++++-------- swh/loader/package/debian/loader.py | 22 +++++++++------ swh/loader/package/debian/tests/test_debian.py | 4 +-- swh/loader/package/deposit/loader.py | 27 ++++++++++-------- swh/loader/package/loader.py | 39 +++++++++++++++++++------- swh/loader/package/nixguix/loader.py | 20 +++++++++---- swh/loader/package/npm/loader.py | 18 ++++++------ swh/loader/package/pypi/loader.py | 23 +++++++-------- 10 files changed, 132 insertions(+), 80 deletions(-)
Changes applied before test
commit 68902739138ba4ce282572dd66e55c048eaa1310
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Jul 22 11:58:32 2020 +0200
Use an attr class for p_info instead of a dict.
The benefits are minimal for now, as 'raw' still contains a lot of stuff;
but further commits will move data out of 'raw' to a proper attribute.
commit 1fbbf14ed01e6fc9852f9b54f1b60b14f19a5515
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 23 13:31:09 2020 +0200
test_resolve_revision_from_edge_cases: fix argument names/order.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/207/ for more details.
Comment Actions
Nice!
A couple of nits... ;)
| swh/loader/package/cran/loader.py | ||
|---|---|---|
| 66 | might as well make that Iterator[Tuple[str, CranPackageInfo]] now. | |
| swh/loader/package/debian/loader.py | ||
| 96 | same, Iterator... | |
| 110 | p_info.raw now | |
| swh/loader/package/deposit/loader.py | ||
| 117 | well yea, the extrinsic because it got processed by a third party (the deposit server) and raw because the loader did not touch it (afair). | |
| swh/loader/package/loader.py | ||
| 103 | Iterator... | |
| swh/loader/package/nixguix/loader.py | ||
| 68 | Iterator... | |
| swh/loader/package/npm/loader.py | ||
| 73 | Iterator... | |
Comment Actions
Build is green
Patch application report for D3602 (id=12693)
Could not rebase; Attempt merge onto 2699a1f629...
Updating 2699a1f..1050d94 Fast-forward swh/loader/cli.py | 10 +++++-- swh/loader/package/archive/loader.py | 27 ++++++++++------- swh/loader/package/cran/loader.py | 28 +++++++++--------- swh/loader/package/debian/loader.py | 24 ++++++++------- swh/loader/package/debian/tests/test_debian.py | 4 +-- swh/loader/package/deposit/loader.py | 27 ++++++++++------- swh/loader/package/loader.py | 41 ++++++++++++++++++-------- swh/loader/package/nixguix/loader.py | 18 +++++++---- swh/loader/package/npm/loader.py | 20 ++++++------- swh/loader/package/pypi/loader.py | 25 ++++++++-------- 10 files changed, 132 insertions(+), 92 deletions(-)
Changes applied before test
commit 1050d94d871d7f46deb18aa46cc07f95f3932e92
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Jul 22 11:58:32 2020 +0200
Use an attr class for p_info instead of a dict.
The benefits are minimal for now, as 'raw' still contains a lot of stuff;
but further commits will move data out of 'raw' to a proper attribute.
commit 1fbbf14ed01e6fc9852f9b54f1b60b14f19a5515
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 23 13:31:09 2020 +0200
test_resolve_revision_from_edge_cases: fix argument names/order.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/210/ for more details.