pytest_plugin: Do not expose the validate proxy storage
ClosedPublic
Actions

Authored by ardumont on Jul 16 2020, 12:42 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDSTO3abf6b3f7e72: pytest_plugin: Do not expose the validate proxy storage

Summary

Only the storage module needs it (because it's manipulating data as dict, which
i'm migrating away from in the intent to remove that validate proxy storage altogether
but it's taking some time...)

Note: I moved the swh_storage_backend_fixture and swh_storage so they are placed
before the other fixtures which use it (so the reading order is more natural).

This should fix the debian jenkins build [1]

[1] https://jenkins.softwareheritage.org/view/Debian%20packages/job/debian/job/packages/job/DLDBASE/job/gbp-buildpackage/153/console

^ the feedback loop for that is not good at all...

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 16 2020, 12:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2020, 12:42 PM

Build is green

Patch application report for D3528 (id=12458)

Rebasing onto 21efe2a09e...

Current branch diff-target is up to date.

Changes applied before test

commit 8f4b054a308c34a257f981520d5fbb35478d4d5c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 12:30:55 2020 +0200

    pytest_plugin: Do not expose the validate proxy storage
    
    Only the storage module needs it.
    
    This should fix the debian jenkins build [1]
    
    [1] https://jenkins.softwareheritage.org/view/Debian%20packages/job/debian/job/packages/job/DLDBASE/job/gbp-buildpackage/153/console

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/465/ for more details.

Harbormaster completed remote builds in B13680: Diff 12458.Jul 16 2020, 12:48 PM

ardumont edited the summary of this revision. (Show Details)Jul 16 2020, 12:48 PM

ardumont edited the summary of this revision. (Show Details)Jul 16 2020, 1:45 PM

ardumont edited the summary of this revision. (Show Details)Jul 16 2020, 1:47 PM

Rebase

Build is green

Patch application report for D3528 (id=12460)

Rebasing onto a688e822a8...

Current branch diff-target is up to date.

Changes applied before test

commit 3abf6b3f7e72b16b8b91dfac9d45ddc1b7fad072
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 12:30:55 2020 +0200

    pytest_plugin: Do not expose the validate proxy storage
    
    Only the storage module needs it.
    
    This should fix the debian jenkins build [1]
    
    [1] https://jenkins.softwareheritage.org/view/Debian%20packages/job/debian/job/packages/job/DLDBASE/job/gbp-buildpackage/153/console

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/466/ for more details.

Harbormaster completed remote builds in B13682: Diff 12460.Jul 16 2020, 2:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 16 2020, 2:23 PM

Closed by commit rDSTO3abf6b3f7e72: pytest_plugin: Do not expose the validate proxy storage (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO3abf6b3f7e72: pytest_plugin: Do not expose the validate proxy storage.