Differential D3524

Only include relevant data files in MANIFEST.in
ClosedPublic
Actions

Authored by olasd on Jul 16 2020, 12:17 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLSd0c1df65f1f4: Only include relevant data files in MANIFEST.in

Summary

The previous include would pull all .mypy_cache directories too, which are quite
large as they include the SQLAlchemy stubs.

Test Plan

tox takes less than 3 minutes to create the sdist and venvs, when
mypy has been run.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jul 16 2020, 12:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2020, 12:17 PM

ouch!

Nice catch.

This revision is now accepted and ready to land.Jul 16 2020, 12:21 PM

Build is green

Patch application report for D3524 (id=12450)

Rebasing onto 5f1fbbe8a4...

Current branch diff-target is up to date.

Changes applied before test

commit d0c1df65f1f4b05cd9e766ee3916d25182ecdb25
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jul 16 10:27:54 2020 +0200

    Only include relevant data files in MANIFEST.in
    
    The previous include would pull all .mypy_cache directories too, which are quite
    large as they include the SQLAlchemy stubs.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/20/ for more details.

Harbormaster completed remote builds in B13672: Diff 12450.Jul 16 2020, 12:21 PM

olasd added a child revision: D3525: Move get_scheduler monkeypatching into an explicit pytest fixture.Jul 16 2020, 12:21 PM

Closed by commit rDLSd0c1df65f1f4: Only include relevant data files in MANIFEST.in (authored by olasd). · Explain WhyJul 22 2020, 12:47 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDLSd0c1df65f1f4: Only include relevant data files in MANIFEST.in.