Differential D3522

tests: Drop no longer used loader base tests code
ClosedPublic
Actions

Authored by ardumont on Jul 16 2020, 11:45 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2488: Drop loader.core BaseLoaderTest and BaseLoaderStorageTest

Commits

rDLDBASE070c962e4eff: tests: Drop no longer used base tests code

Summary

No longer used (finally)

$ cd swh-environment
$ grep -r "BaseLoaderStorageTest" **/swh/*
Binary file swh-loader-core/swh/loader/core/tests/__pycache__/test_tests.cpython-37-pytest-5.4.3.pyc matches
Binary file swh-loader-core/swh/loader/core/tests/__pycache__/__init__.cpython-37-pytest-5.4.3.pyc matches
$ grep -r "BaseLoaderTest" **/swh/*
Binary file swh-loader-core/swh/loader/core/tests/__pycache__/test_tests.cpython-37-pytest-5.4.3.pyc matches
Binary file swh-loader-core/swh/loader/core/tests/__pycache__/__init__.cpython-37-pytest-5.4.3.pyc matches

Related to T2488

Test Plan

tox

coverage increased a bit (94% -> 96%), here is before:

TOTAL                                                                                    3104    129    546     50    94%
====================================================================================================== 141 passed, 8 warnings in 22.13s =======================================================================================================

after:

====================================================================================================== 138 passed, 8 warnings in 22.04s =======================================================================================================
TOTAL                                                                                    2976     92    520     49    96%

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13663
Build 20932: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20931: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 16 2020, 11:45 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2020, 11:45 AM

ardumont edited the test plan for this revision. (Show Details)Jul 16 2020, 11:46 AM

Build is green

Patch application report for D3522 (id=12441)

Rebasing onto 28b35a18c7...

Current branch diff-target is up to date.

Changes applied before test

commit 070c962e4effbf00841da2f684aad242ed82aad5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 11:44:41 2020 +0200

    tests: Drop no longer used base tests code
    
    Related to T2488

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/161/ for more details.

Harbormaster completed remote builds in B13663: Diff 12441.Jul 16 2020, 11:47 AM

ardumont edited the test plan for this revision. (Show Details)Jul 16 2020, 11:47 AM

ardumont edited the test plan for this revision. (Show Details)

ardumont edited the summary of this revision. (Show Details)

ardumont retitled this revision from tests: Drop no longer used base tests code to tests: Drop no longer used loader base tests code.Jul 16 2020, 11:51 AM

ardumont edited the test plan for this revision. (Show Details)Jul 16 2020, 1:39 PM

ardumont edited the test plan for this revision. (Show Details)