Differential D3499

Fix branches types in tests
ClosedPublic
Actions

Authored by douardda on Jul 10 2020, 4:04 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDHGeb613d754dab: Fix branches types in tests

Summary

branch names and targets are expected to be bytes.

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jul 10 2020, 4:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 10 2020, 4:04 PM

Build has FAILED

Patch application report for D3499 (id=12362)

Rebasing onto 385dacfae8...

Current branch diff-target is up to date.

Changes applied before test

commit bc8a56865da3465284c17a55c81f8e082a856177
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 16:03:38 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/26/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/26/console

Harbormaster failed remote builds in B13585: Diff 12362!Jul 10 2020, 4:06 PM

douardda mentioned this in D3501: Use bytes as snapshot id and get rid of dict manipulation in check_snapshot().Jul 10 2020, 4:50 PM

Build is green

Patch application report for D3499 (id=12362)

Rebasing onto 385dacfae8...

Current branch diff-target is up to date.

Changes applied before test

commit bc8a56865da3465284c17a55c81f8e082a856177
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 16:03:38 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/27/ for more details.

Harbormaster completed remote builds in B13585: Diff 12362.Jul 15 2020, 2:25 PM

bump dep on swh.loader.core

ardumont accepted this revision.Jul 15 2020, 4:00 PM

This revision is now accepted and ready to land.Jul 15 2020, 4:00 PM

Build is green

Patch application report for D3499 (id=12408)

Rebasing onto 385dacfae8...

Current branch diff-target is up to date.

Changes applied before test

commit eb613d754dabdb9cdd6961af39dfd85941619ca0
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 16:03:38 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/28/ for more details.

Harbormaster completed remote builds in B13628: Diff 12408.Jul 15 2020, 4:01 PM

Closed by commit rDLDHGeb613d754dab: Fix branches types in tests (authored by douardda). · Explain WhyJul 15 2020, 4:03 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDLDHGeb613d754dab: Fix branches types in tests.