Differential D3498

Fix branches types in tests
ClosedPublic
Actions

Authored by douardda on Jul 10 2020, 3:58 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVN9d16dc0f2283: Fix branches types in tests

Summary

branch names and targets are expected to be bytes.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jul 10 2020, 3:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 10 2020, 3:58 PM

Build has FAILED

Patch application report for D3498 (id=12361)

Rebasing onto efe886a0b8...

Current branch diff-target is up to date.

Changes applied before test

commit ac1cf7a04e5bd1a54251a44c636eebd8933fab55
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:58:09 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/74/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/74/console

Harbormaster failed remote builds in B13584: Diff 12361!Jul 10 2020, 4:00 PM

douardda mentioned this in D3501: Use bytes as snapshot id and get rid of dict manipulation in check_snapshot().Jul 10 2020, 4:50 PM

Build is green

Patch application report for D3498 (id=12361)

Rebasing onto efe886a0b8...

Current branch diff-target is up to date.

Changes applied before test

commit ac1cf7a04e5bd1a54251a44c636eebd8933fab55
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:58:09 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/75/ for more details.

Harbormaster completed remote builds in B13584: Diff 12361.Jul 15 2020, 2:25 PM

Bump dep on swh.loader.core

ardumont accepted this revision.Jul 15 2020, 3:59 PM

This revision is now accepted and ready to land.Jul 15 2020, 3:59 PM

Build is green

Patch application report for D3498 (id=12407)

Rebasing onto efe886a0b8...

Current branch diff-target is up to date.

Changes applied before test

commit 5768d854c31632194fa496b8e2d66dd54df45436
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:58:09 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/76/ for more details.

Harbormaster completed remote builds in B13627: Diff 12407.Jul 15 2020, 4:00 PM

same with actual commit included

Build is green

Patch application report for D3498 (id=12409)

Rebasing onto efe886a0b8...

Current branch diff-target is up to date.

Changes applied before test

commit 9d16dc0f2283b47b11a37b72b8a5e03aff0f2afa
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:58:09 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/77/ for more details.

Harbormaster completed remote builds in B13629: Diff 12409.Jul 15 2020, 4:03 PM

Closed by commit rDLDSVN9d16dc0f2283: Fix branches types in tests (authored by douardda). · Explain WhyJul 15 2020, 4:04 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDLDSVN9d16dc0f2283: Fix branches types in tests.