Differential D3497

Explicit types in init files
ClosedPublic
Actions

Authored by ardumont on Jul 10 2020, 3:52 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDLDBASEae7e38882313: Explicit types in __init__ files

Summary

Got annoyed at those being highlighted when i opened those by mistake ¯\_(ツ)_/¯

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 10 2020, 3:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 10 2020, 3:52 PM

Build is green

Patch application report for D3497 (id=12360)

Could not rebase; Attempt merge onto 72590f9980...

Updating 72590f9..92e6ad5
Fast-forward
 conftest.py                 | 51 +++++--------------------------------------
 pytest.ini                  |  2 --
 swh/__init__.py             |  7 +++++-
 swh/loader/__init__.py      |  7 +++++-
 swh/loader/pytest_plugin.py | 53 +++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 70 insertions(+), 50 deletions(-)
 create mode 100644 swh/loader/pytest_plugin.py

Changes applied before test

commit 92e6ad56f03f4c5b0d56cec6e6c26e3612daa62d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 15:52:01 2020 +0200

    Explicit types in __init__ files

commit 47578a0e7ddf26c0e6d822d345f86fb9c38a17e4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 15:41:44 2020 +0200

    Expose a pytest_plugin module so other loaders can reuse for tests
    
    This does not expose the pytest-plugin through the setuptools entry as this can
    be problematic. Instead that relies on the speific modules (loader-*) needing
    it to declare that needed dependency in their root conftest.

commit 604352e710952db1fece8becfb757fb56a800ef8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 15:30:35 2020 +0200

    pytest: Remove no longer needed pytest setup
    
    Both swh.scheduler and swh.storage stopped exporting this plugin automatically.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/139/ for more details.

Harbormaster completed remote builds in B13583: Diff 12360.Jul 10 2020, 3:54 PM

Rebase

Build is green

Patch application report for D3497 (id=12367)

Could not rebase; Attempt merge onto fe28c44349...

Updating fe28c44..3158035
Fast-forward
 conftest.py                 | 51 +++++--------------------------------------
 pytest.ini                  |  2 --
 swh/__init__.py             |  7 +++++-
 swh/loader/__init__.py      |  7 +++++-
 swh/loader/pytest_plugin.py | 53 +++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 70 insertions(+), 50 deletions(-)
 create mode 100644 swh/loader/pytest_plugin.py

Changes applied before test

commit 315803562491273871e8a716d621cec2cb3c3524
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 15:52:01 2020 +0200

    Explicit types in __init__ files

commit e2658c8e3dfe5680e6552e5e08cee7413d48dc80
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 15:41:44 2020 +0200

    Expose a pytest_plugin module so other loaders can reuse for tests
    
    This does not expose the pytest-plugin through the setuptools entry as this can
    be problematic. Instead that relies on the speific modules (loader-*) needing
    it to declare that needed dependency in their root conftest.

commit 59bddb8446d072cea5b549853742d01027632a76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 15:30:35 2020 +0200

    pytest: Remove no longer needed pytest setup
    
    Both swh.scheduler and swh.storage stopped exporting this plugin automatically.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/142/ for more details.

Harbormaster completed remote builds in B13591: Diff 12367.Jul 10 2020, 4:21 PM

douardda accepted this revision.Jul 10 2020, 4:45 PM

This revision is now accepted and ready to land.Jul 10 2020, 4:45 PM

Rebase on latest master

Build is green

Patch application report for D3497 (id=12375)

Rebasing onto fcc7e61bf9...

Current branch diff-target is up to date.

Changes applied before test

commit ae7e388823135b0288933d4d8291dfe1c3b6ad50
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 10 15:52:01 2020 +0200

    Explicit types in __init__ files

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/146/ for more details.

Harbormaster completed remote builds in B13598: Diff 12375.Jul 10 2020, 4:53 PM

Closed by commit rDLDBASEae7e38882313: Explicit types in __init__ files (authored by ardumont). · Explain WhyJul 10 2020, 4:56 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEae7e38882313: Explicit types in __init__ files.