Page MenuHomeSoftware Heritage

Fix branches types in tests
ClosedPublic

Authored by douardda on Jul 10 2020, 3:31 PM.

Details

Summary

branch names and targets are expected to be bytes.
This should allow to get rid of the type castings in check_snapshot().

Also inclde a small code improvement in package/loader.py

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jul 10 2020, 3:31 PM

Build is green

Patch application report for D3494 (id=12357)

Rebasing onto 72590f9980...

Current branch diff-target is up to date.
Changes applied before test
commit 79251983cbe23cde8e2d71f17a9f812856f5d698
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:24:59 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.
    This should allow to get rid of the type castings in check_snapshot().

commit d943aed979edc40d8329ad6212279efa49881b0b
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Jul 6 15:47:40 2020 +0200

    Small code improvement in package/loader.py

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/137/ for more details.

ardumont accepted this revision.Jul 10 2020, 3:36 PM
ardumont added a subscriber: ardumont.

id should be bytes as well
but that can be an extra diff (as you wish).

This revision is now accepted and ready to land.Jul 10 2020, 3:36 PM
douardda updated this revision to Diff 12369.Jul 10 2020, 4:26 PM

Forgot one occurrence

Build is green

Patch application report for D3494 (id=12369)

Rebasing onto fe28c44349...

First, rewinding head to replay your work on top of it...
Applying: Small code improvement in package/loader.py
Applying: Fix branches types in tests
Changes applied before test
commit 5846e7a066280ea2ec1905b4d3e0d0bf0d3ee6bb
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:24:59 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.
    This should allow to get rid of the type castings in check_snapshot().

commit 76b59f2300d8556cb180b35b0c8630e51b995aa3
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Jul 6 15:47:40 2020 +0200

    Small code improvement in package/loader.py

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/143/ for more details.

Build is green

Patch application report for D3494 (id=12371)

Rebasing onto fe28c44349...

Current branch diff-target is up to date.
Changes applied before test
commit fcc7e61bf9c9aaca587f218fa0beeb32e5b5ae29
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 10 15:24:59 2020 +0200

    Fix branches types in tests
    
    branch names and targets are expected to be bytes.
    This should allow to get rid of the type castings in check_snapshot().

commit c05adcaf5c288f1d51f6d153695d71ee6a97bd52
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Jul 6 15:47:40 2020 +0200

    Small code improvement in package/loader.py

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/144/ for more details.