Differential D3489

Rework dia -> pdf pipeline for inkscape 1.0
ClosedPublic
Actions

Authored by olasd on Jul 9 2020, 7:36 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDMODbf4353663b2c: Rework dia -> pdf pipeline for inkscape 1.0

Summary

Use dia directly to convert from .dia to .svg (inkscape would use dia via a plugin anyway)
Add proper runes to detect inkscape >= 1 and use the export options for that.

Test Plan

make -C docs/images

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jul 9 2020, 7:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 9 2020, 7:36 PM

anlambert accepted this revision.Jul 9 2020, 7:37 PM

This revision is now accepted and ready to land.Jul 9 2020, 7:37 PM

Build is green

Patch application report for D3489 (id=12336)

Rebasing onto 0547a516e6...

Current branch diff-target is up to date.

Changes applied before test

commit bf4353663b2caa7e3492905f14fbfbc93758b560
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jul 9 19:35:21 2020 +0200

    Rework dia -> pdf pipeline for inkscape 1.0
    
     - Use dia directly to convert from .dia to .svg (inkscape would use dia via a
     plugin anyway)
     - Add proper runes to detect inkscape >= 1 and use the export options for that.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/122/ for more details.

Harbormaster completed remote builds in B13558: Diff 12336.Jul 9 2020, 7:38 PM

Closed by commit rDMODbf4353663b2c: Rework dia -> pdf pipeline for inkscape 1.0 (authored by olasd). · Explain WhyJul 9 2020, 7:40 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDMODbf4353663b2c: Rework dia -> pdf pipeline for inkscape 1.0.