Differential D3480

Use the new names for the swh.scheduler test fixtures
ClosedPublic
Actions

Authored by olasd on Jul 9 2020, 5:16 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLSc9963d4302b9: Use the new names for the swh.scheduler test fixtures

Summary

Allows us to move on from importing * from other modules' conftest.py.
This will also let us stop exporting the swh.scheduler pytest fixture by
default.

Test Plan

tox tests pass

Diff Detail

Repository

rDLS Listers

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13532
Build 20710: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20709: arc lint + arc unit

Event Timeline

olasd created this revision.Jul 9 2020, 5:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 9 2020, 5:16 PM

Build is green

Patch application report for D3480 (id=12311)

Rebasing onto 014c446d05...

Current branch diff-target is up to date.

Changes applied before test

commit c9963d4302b93c58b60800b058a2c66a10a6fa7e
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jul 9 12:14:42 2020 +0200

    Use the new names for the swh.scheduler test fixtures

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/16/ for more details.

Harbormaster completed remote builds in B13532: Diff 12311.Jul 9 2020, 5:20 PM

Thanks.

This revision is now accepted and ready to land.Jul 9 2020, 5:24 PM

ardumont added inline comments.Jul 9 2020, 5:27 PM

pytest.ini
4	ugh, that part is surprising ¯\_(ツ)_/¯

ardumont added inline comments.Jul 9 2020, 5:29 PM

pytest.ini
4	ah but yeah! right now we expose the pytest-plugin through setupentry both in scheduler and storage. We'll be able to remove it when we stop doing that (soon hopefully ;)
4	setuptool entry*...