Page MenuHomeSoftware Heritage

Require explicitely the dependencies on storage fixtures
AbandonedPublic

Authored by ardumont on Jul 9 2020, 4:28 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

Related to D3475

Test Plan

tox
(failing until master build is fixed and new storage v0.10.2 is released)

Diff Detail

Repository
rDLDHG Mercurial loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13530
Build 20707: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 20706: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 9 2020, 4:28 PM

Build has FAILED

Patch application report for D3479 (id=12310)

Rebasing onto 4dbf2c03f2...

Current branch diff-target is up to date.
Changes applied before test
commit 38157f84db28a08c4191eb6d8125c4a679bfb44f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 9 16:23:10 2020 +0200

    Require explicitely the dependencies on storage fixtures
    
    This drops the duplicated tox.ini entry wrongly added to satisfy tox.
    
    Related to D3475

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/24/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/24/console

ardumont added inline comments.Jul 9 2020, 4:31 PM
conftest.py
1

In a dedicated top-level conftest as otherwise, pytest complains about it:

________________________________________________________________________________________________________ ERROR collecting test session ________________________________________________________________________________________________________
Defining 'pytest_plugins' in a non-top-level conftest is no longer supported:
It affects the entire test suite instead of just below the conftest as expected.
  /home/tony/work/inria/repo/swh/swh-environment/swh-loader-mercurial/swh/loader/mercurial/tests/conftest.py
Please move it to a top level conftest file at the rootdir:
  /home/tony/work/inria/repo/swh/swh-environment/swh-loader-mercurial
For more information, visit:
  https://docs.pytest.org/en/latest/deprecations.html#pytest-plugins-in-non-top-level-conftest-files
ardumont abandoned this revision.Jul 9 2020, 6:33 PM