Differential D3477

Fix a typo in previous revision
ClosedPublic
Actions

Authored by douardda on Jul 9 2020, 11:56 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSTOc3803ef8f797: Fix a typo I introduced in previous revision

Summary

dict(x if x is not None else None) != dict(x) if x is not None else None...

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jul 9 2020, 11:56 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 9 2020, 11:56 AM

make sure there is no doubt on who the dumb fellow is

Build has FAILED

Patch application report for D3477 (id=12296)

Rebasing onto 8bf3794874...

Current branch diff-target is up to date.

Changes applied before test

commit bf6dad9a3b417c0beab1480394f8543958dc1eb6
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Jul 9 11:54:07 2020 +0200

    Fix a typo in previous revision
    
    dict(x if x is not None else None) != dict(x) if x is not None else None...

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/430/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/430/console

Harbormaster failed remote builds in B13515: Diff 12296!Jul 9 2020, 12:04 PM

Build has FAILED

Patch application report for D3477 (id=12297)

Rebasing onto 8bf3794874...

Current branch diff-target is up to date.

Changes applied before test

commit c3803ef8f79765c5ff4f0e13e115779aea7ad38f
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Jul 9 11:54:07 2020 +0200

    Fix a typo I introduced in previous revision
    
    dict(x if x is not None else None) != dict(x) if x is not None else None...

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/431/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/431/console

Harbormaster failed remote builds in B13516: Diff 12297!Jul 9 2020, 12:12 PM

Build has FAILED

Patch application report for D3477 (id=12296)

Rebasing onto 8bf3794874...

Current branch diff-target is up to date.

Changes applied before test

commit bf6dad9a3b417c0beab1480394f8543958dc1eb6
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Jul 9 11:54:07 2020 +0200

    Fix a typo in previous revision
    
    dict(x if x is not None else None) != dict(x) if x is not None else None...

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/432/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/432/console

olasd accepted this revision.Jul 9 2020, 12:26 PM

This revision is now accepted and ready to land.Jul 9 2020, 12:26 PM

This revision was landed with ongoing or failed builds.Jul 9 2020, 12:47 PM

Closed by commit rDSTOc3803ef8f797: Fix a typo I introduced in previous revision (authored by douardda). · Explain Why

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSTOc3803ef8f797: Fix a typo I introduced in previous revision.