Differential D3460

test_serializers: Move to pytest for that specific erratic assertion
ClosedPublic
Actions

Authored by ardumont on Jul 8 2020, 1:15 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDCORE737b21d3dd66: test_serializers: Move to pytest for that specific erratic assertion

Summary

Ideally we should refactor those entirely.

Should definitely fix the debian build [1]

[1] https://jenkins.softwareheritage.org/job/debian/job/packages/job/DCORE/job/gbp-buildpackage/118/console

rDCORE84c7319bc37abb5fd97af994a9527ae01218ee44 was not enough.

Got mislead by pytest's better raises function apparently. Although neither tox nor pytest pick it up... i don't get why but meh...
Let's unstuck the build.

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 8 2020, 1:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 8 2020, 1:15 PM

Build is green

Patch application report for D3460 (id=12246)

Rebasing onto 84c7319bc3...

Current branch diff-target is up to date.

Changes applied before test

commit 737b21d3dd6641ca62f99fec4fd0185df6af72a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 8 13:13:31 2020 +0200

    test_serializers: Move to pytest for that specific erratic assertion
    
    Ideally we should refactor those entirely.
    
    Should definitely fix the debian build [1]
    
    [1] https://jenkins.softwareheritage.org/job/debian/job/packages/job/DCORE/job/gbp-buildpackage/118/console

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/19/ for more details.

Harbormaster completed remote builds in B13465: Diff 12246.Jul 8 2020, 1:17 PM

ardumont edited the summary of this revision. (Show Details)Jul 8 2020, 1:17 PM

anlambert accepted this revision.Jul 8 2020, 1:21 PM

This revision is now accepted and ready to land.Jul 8 2020, 1:21 PM

Closed by commit rDCORE737b21d3dd66: test_serializers: Move to pytest for that specific erratic assertion (authored by ardumont). · Explain WhyJul 8 2020, 1:38 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCORE737b21d3dd66: test_serializers: Move to pytest for that specific erratic assertion.

ardumont mentioned this in D3461: test_serializers: Refactor using pytest.Jul 8 2020, 3:24 PM