Differential D3422

Don't recurse into attrs objects when serializing
ClosedPublic
Actions

Authored by olasd on Jul 6 2020, 9:52 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSCHaefc5c97f80a: Don't recurse into attrs objects when serializing

Summary

We need to use our serialization hook recursively to make sure that we can
deserialize nested data structures.

Test Plan

Will be used in further commits.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jul 6 2020, 9:52 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 6 2020, 9:52 AM

olasd added a child revision: D3423: Introduce a get_listed_origins endpoint.Jul 6 2020, 9:52 AM

Build is green

Patch application report for D3422 (id=12122)

Rebasing onto cc8fa7f4c0...

Current branch diff-target is up to date.

Changes applied before test

commit aefc5c97f80ae869447165c12620df5ff1775afc
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jul 6 09:48:29 2020 +0200

    Don't recurse into attrs objects when serializing
    
    We need to use our serialization hook recursively to make sure that we can
    deserialize nested data structures.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/33/ for more details.

Harbormaster completed remote builds in B13343: Diff 12122.Jul 6 2020, 9:55 AM

vlorentz accepted this revision.Jul 6 2020, 10:49 AM

This revision is now accepted and ready to land.Jul 6 2020, 10:49 AM

Closed by commit rDSCHaefc5c97f80a: Don't recurse into attrs objects when serializing (authored by olasd). · Explain WhyJul 6 2020, 12:16 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSCHaefc5c97f80a: Don't recurse into attrs objects when serializing.