Page MenuHomeSoftware Heritage
Differential D3418

Implement to_dict and from_dict for metadata-related classes.
ClosedPublic
Actions

Authored by vlorentz on Jul 3 2020, 5:10 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDMOD9e475a702a3b: Implement to_dict and from_dict for metadata-related classes.
Summary

Depends on D3396 and D3417

Diff Detail

Repository
rDMOD Data model
Branch
metadata-to-from-dict
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13358
Build 20418: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 20417: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 3 2020, 5:10 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2020, 5:10 PM
swh-public-ci added a comment.Jul 3 2020, 5:12 PM

Build is green

Patch application report for D3418 (id=12115)

Could not rebase; Attempt merge onto 1ff05161e7...

Merge made by the 'recursive' strategy.
 swh/model/collections.py            |  36 +++
 swh/model/model.py                  | 318 +++++++++++++++++++++++++-
 swh/model/tests/test_collections.py |  42 ++++
 swh/model/tests/test_model.py       | 441 ++++++++++++++++++++++++++++++++++++
 4 files changed, 827 insertions(+), 10 deletions(-)
 create mode 100644 swh/model/collections.py
 create mode 100644 swh/model/tests/test_collections.py
Changes applied before test
commit da31605b8013d61f1bcd81b11d4de7ce894b31d9
Merge: 1ff0516 3c4e226
Author: Jenkins user <jenkins@localhost>
Date:   Fri Jul 3 15:10:49 2020 +0000

    Merge branch 'diff-target' into HEAD

commit 3c4e2268457fefe802052c458523e329917f095a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:10:08 2020 +0200

    Implement to_dict and from_dict for metadata-related classes.

commit 5b7ac4fdf7c465def8303f2184ae9e0097983eca
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:08:19 2020 +0200

    Add a new ImmutableDict class, and use it in model objects.
    
    So they are truly immutable now.

commit 5e3ae76689895f5bccb62cccca813f3810231a85
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 2 17:53:13 2020 +0200

    Add raw metadata to the model.
    
    This will allow swh-storage to have a signature for *_metadata_add
    that is consistent with other *_add endpoints.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/102/ for more details.

Harbormaster completed remote builds in B13336: Diff 12115.Jul 3 2020, 5:12 PM
vlorentz updated this revision to Diff 12135.Jul 6 2020, 12:00 PM

rebase + rename to SWHID

swh-public-ci added a comment.Jul 6 2020, 12:03 PM

Build has FAILED

Patch application report for D3418 (id=12135)

Could not rebase; Attempt merge onto 1ff05161e7...

Updating 1ff0516..fc569b4
Fast-forward
 swh/model/collections.py            |  36 +++
 swh/model/model.py                  | 310 ++++++++++++++++++++++++-
 swh/model/tests/test_collections.py |  42 ++++
 swh/model/tests/test_model.py       | 439 ++++++++++++++++++++++++++++++++++++
 4 files changed, 817 insertions(+), 10 deletions(-)
 create mode 100644 swh/model/collections.py
 create mode 100644 swh/model/tests/test_collections.py
Changes applied before test
commit fc569b4469d8e1ad6d9c7c9352b231b6ee292647
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:10:08 2020 +0200

    Implement to_dict and from_dict for metadata-related classes.

commit 408e638b1dffe99e1afb1a3c77dbe0e14cb56042
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:08:19 2020 +0200

    Add a new ImmutableDict class, and use it in model objects.
    
    So they are truly immutable now.

commit d4ea9a56aca02b8aed15186372749bfbe639d69f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 2 17:53:13 2020 +0200

    Add raw metadata to the model.
    
    This will allow swh-storage to have a signature for *_metadata_add
    that is consistent with other *_add endpoints.

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/107/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/107/console

Harbormaster failed remote builds in B13357: Diff 12135!Jul 6 2020, 12:03 PM
vlorentz updated this revision to Diff 12136.Jul 6 2020, 12:08 PM

forgot one renaming

swh-public-ci added a comment.Jul 6 2020, 12:10 PM

Build is green

Patch application report for D3418 (id=12136)

Could not rebase; Attempt merge onto 1ff05161e7...

Updating 1ff0516..aba3485
Fast-forward
 swh/model/collections.py            |  36 +++
 swh/model/model.py                  | 310 ++++++++++++++++++++++++-
 swh/model/tests/test_collections.py |  42 ++++
 swh/model/tests/test_model.py       | 439 ++++++++++++++++++++++++++++++++++++
 4 files changed, 817 insertions(+), 10 deletions(-)
 create mode 100644 swh/model/collections.py
 create mode 100644 swh/model/tests/test_collections.py
Changes applied before test
commit aba34856f7bba81de05b24e40f0e325e024dcb8e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:10:08 2020 +0200

    Implement to_dict and from_dict for metadata-related classes.

commit 408e638b1dffe99e1afb1a3c77dbe0e14cb56042
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:08:19 2020 +0200

    Add a new ImmutableDict class, and use it in model objects.
    
    So they are truly immutable now.

commit d4ea9a56aca02b8aed15186372749bfbe639d69f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 2 17:53:13 2020 +0200

    Add raw metadata to the model.
    
    This will allow swh-storage to have a signature for *_metadata_add
    that is consistent with other *_add endpoints.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/108/ for more details.

Harbormaster completed remote builds in B13358: Diff 12136.Jul 6 2020, 12:10 PM
ardumont accepted this revision.Jul 6 2020, 6:08 PM
This revision is now accepted and ready to land.Jul 6 2020, 6:08 PM
vlorentz updated this revision to Diff 12185.Jul 7 2020, 11:49 AM

rebase

swh-public-ci added a comment.Jul 7 2020, 11:53 AM

Build has FAILED

Patch application report for D3418 (id=12185)

Could not rebase; Attempt merge onto a7d9aca2b0...

Updating a7d9aca..b9d10d7
Fast-forward
 swh/model/collections.py            |  36 +++
 swh/model/model.py                  | 310 ++++++++++++++++++++++++-
 swh/model/tests/test_collections.py |  42 ++++
 swh/model/tests/test_model.py       | 439 ++++++++++++++++++++++++++++++++++++
 4 files changed, 817 insertions(+), 10 deletions(-)
 create mode 100644 swh/model/collections.py
 create mode 100644 swh/model/tests/test_collections.py
Changes applied before test
commit b9d10d7c12a56756583ffe08f637b1cfd85cdb7c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:10:08 2020 +0200

    Implement to_dict and from_dict for metadata-related classes.

commit 7e870da44f87655ce027876a3b3885d60b8ffc57
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:08:19 2020 +0200

    Add a new ImmutableDict class, and use it in model objects.
    
    So they are truly immutable now.

commit 78fc5f7cbc500bde5d917b8f55fc6c9e79608479
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 2 17:53:13 2020 +0200

    Add raw metadata to the model.
    
    This will allow swh-storage to have a signature for *_metadata_add
    that is consistent with other *_add endpoints.

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/111/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/111/console

Harbormaster failed remote builds in B13405: Diff 12185!Jul 7 2020, 11:53 AM
vlorentz updated this revision to Diff 12199.Jul 7 2020, 1:20 PM

rebase

swh-public-ci added a comment.Jul 7 2020, 1:21 PM

Build has FAILED

Patch application report for D3418 (id=12199)

Rebasing onto a7d9aca2b0...

Current branch diff-target is up to date.
Changes applied before test
commit dd4b93ca1aae722b6ca692b08483fe21d4365581
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:10:08 2020 +0200

    Implement to_dict and from_dict for metadata-related classes.

commit 2628ba1ab3e2163a043c2f1571c7a2a640d12cb0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:08:19 2020 +0200

    Add a new ImmutableDict class, and use it in model objects.
    
    So they are truly immutable now.

commit 78fc5f7cbc500bde5d917b8f55fc6c9e79608479
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 2 17:53:13 2020 +0200

    Add raw metadata to the model.
    
    This will allow swh-storage to have a signature for *_metadata_add
    that is consistent with other *_add endpoints.

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/113/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/113/console

Harbormaster failed remote builds in B13419: Diff 12199!Jul 7 2020, 1:21 PM
vlorentz updated this revision to Diff 12202.Jul 7 2020, 1:31 PM

rebase

swh-public-ci added a comment.Jul 7 2020, 1:36 PM

Build is green

Patch application report for D3418 (id=12202)

Could not rebase; Attempt merge onto a7d9aca2b0...

Updating a7d9aca..9e475a7
Fast-forward
 swh/model/collections.py            |  49 ++++
 swh/model/model.py                  | 318 ++++++++++++++++++++++++--
 swh/model/tests/test_collections.py |  50 ++++
 swh/model/tests/test_model.py       | 439 ++++++++++++++++++++++++++++++++++++
 4 files changed, 841 insertions(+), 15 deletions(-)
 create mode 100644 swh/model/collections.py
 create mode 100644 swh/model/tests/test_collections.py
Changes applied before test
commit 9e475a702a3b475a4edd5aca4f01f8f03b6e4f78
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:10:08 2020 +0200

    Implement to_dict and from_dict for metadata-related classes.

commit af0dd1aaee4943d6cec0f50f77a14bcd4d8733b5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 3 17:08:19 2020 +0200

    Add a new ImmutableDict class, and use it in model objects.
    
    So they are truly immutable now.

commit 78fc5f7cbc500bde5d917b8f55fc6c9e79608479
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jul 2 17:53:13 2020 +0200

    Add raw metadata to the model.
    
    This will allow swh-storage to have a signature for *_metadata_add
    that is consistent with other *_add endpoints.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/116/ for more details.

Harbormaster completed remote builds in B13422: Diff 12202.Jul 7 2020, 1:36 PM
Closed by commit rDMOD9e475a702a3b: Implement to_dict and from_dict for metadata-related classes. (authored by vlorentz). · Explain WhyJul 7 2020, 2:27 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDMOD9e475a702a3b: Implement to_dict and from_dict for metadata-related classes..

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
model/
55 lines97%
Loading...
tests/
32 lines98%
Loading...

Diff 12136

View Options

swh/model/model.py

Loading...
View Options

swh/model/tests/test_model.py

Loading...
About · Developer information · Legal