Differential D3392

loader-core: Reuse swh.model.from_disk.iter_directory function
ClosedPublic
Actions

Authored by ardumont on Jul 2 2020, 12:05 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLDBASEaafac87f5c48: Reuse swh.model.from_disk.iter_directory function

Summary

Depends D3391 (model)

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 2 2020, 12:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 2 2020, 12:05 PM

Build has FAILED

Patch application report for D3392 (id=12035)

Rebasing onto 316f9129dc...

Current branch diff-target is up to date.

Changes applied before test

commit aafac87f5c4870673e43bc061c5647fcb3ad0664
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 12:05:06 2020 +0200

    Reuse swh.model.from_disk.iter_directory function

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/93/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/93/console

Harbormaster failed remote builds in B13255: Diff 12035!Jul 2 2020, 12:06 PM

ardumont mentioned this in D3390: Unify object_type some more within the merkle and from_disk modules.Jul 2 2020, 12:12 PM

anlambert accepted this revision.Jul 2 2020, 2:44 PM

This revision is now accepted and ready to land.Jul 2 2020, 2:44 PM

Build has FAILED

Patch application report for D3392 (id=12035)

Rebasing onto 316f9129dc...

Current branch diff-target is up to date.

Changes applied before test

commit aafac87f5c4870673e43bc061c5647fcb3ad0664
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 12:05:06 2020 +0200

    Reuse swh.model.from_disk.iter_directory function

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/94/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/94/console

Build is green

Patch application report for D3392 (id=12035)

Rebasing onto 316f9129dc...

Current branch diff-target is up to date.

Changes applied before test

commit aafac87f5c4870673e43bc061c5647fcb3ad0664
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 12:05:06 2020 +0200

    Reuse swh.model.from_disk.iter_directory function

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/95/ for more details.

Harbormaster completed remote builds in B13255: Diff 12035.Jul 2 2020, 3:23 PM

ardumont edited the test plan for this revision. (Show Details)Jul 2 2020, 3:23 PM

Closed by commit rDLDBASEaafac87f5c48: Reuse swh.model.from_disk.iter_directory function (authored by ardumont). · Explain WhyJul 2 2020, 3:24 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEaafac87f5c48: Reuse swh.model.from_disk.iter_directory function.